mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Guarantee that the generated password for share will have all the types of characters needed to pass server check

Browse Source 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
This commit is contained in:
Claudio Cambra 2023-05-20 23:30:12 +08:00
parent 32acf504cb
commit f9ded784b5
No known key found for this signature in database
GPG Key ID: C839200C384636B0
1 changed files with 35 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/gui/filedetails/sharemodel.cpp
View File

@ -31,30 +31,56 @@ static const auto secureFileDropPlaceholderLinkShareId = QStringLiteral("__secur
constexpr auto asciiMin = 33;
constexpr auto asciiMax = 126;
constexpr auto asciiRange = asciiMax - asciiMin;
QString createRandomPassword()
{
constexpr auto numChars = 24;
QString passwd;
static constexpr auto numChars = 24;
static constexpr std::string_view lowercaseAlphabet = "abcdefghijklmnopqrstuvwxyz";
static constexpr std::string_view uppercaseAlphabet = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
static constexpr std::string_view numbers = "0123456789";
static constexpr std::string_view specialChars = R"(ªº\\/|"'*+-_´¨{}·#$%&()=\[\]<>;:@~)";
static const QRegularExpression lowercaseMatch("[a-z]");
static const QRegularExpression uppercaseMatch("[A-Z]");
static const QRegularExpression numberMatch("[0-9]");
static const QRegularExpression specialCharMatch(QString("[%1]").arg(specialChars.data()));
static const std::map<std::string_view, QRegularExpression> matchMap {
{ lowercaseAlphabet, lowercaseMatch },
{ uppercaseAlphabet, uppercaseMatch },
{ numbers, numberMatch },
{ specialChars, specialCharMatch },
};
QString passwd;
unsigned char unsignedCharArray[numChars];
RAND_bytes(unsignedCharArray, numChars);
for (auto i = 0; i < numChars; i++) {
auto byte = unsignedCharArray[i];
byte %= asciiRange;
byte %= asciiRange + 1;
byte += asciiMin;
passwd.append(byte);
}
for (auto i = 0; i < remainingChars; i++) {
auto byte = unsignedCharArray[i];
byte %= asciiMax;
for (const auto &charsWithMatcher : matchMap) {
const auto selectionChars = charsWithMatcher.first;
const auto matcher = charsWithMatcher.second;
Q_ASSERT(matcher.isValid());
if (byte >= asciiMin) {
passwd.append(byte);
}
if (matcher.match(passwd).hasMatch()) {
continue;
}
// add random required character at random position
const auto passwdInsertIndex = std::rand() % passwd.length();
const auto charToInsertIndex = std::rand() % selectionChars.length();
const auto charToInsert = selectionChars.at(charToInsertIndex);
passwd.insert(passwdInsertIndex, charToInsert);
}
return passwd;