mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cache NSXPCConnections when starting FileProviderXPC

Browse Source 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
This commit is contained in:
Claudio Cambra 2023-12-05 22:39:05 +08:00
parent 5f6f7f302a
commit ee82968c69
1 changed files with 28 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/gui/macOS/fileproviderxpc_mac.mm
View File

@ -125,6 +125,8 @@ void FileProviderXPC::start()
return;
}
NSMutableArray<NSXPCConnection *> *const connections = NSMutableArray.array;
for (NSDictionary<NSFileProviderServiceName, NSFileProviderService *> *const services in fpServices) {
NSArray<NSFileProviderServiceName> *const serviceNamesArray = services.allKeys;
@ -153,25 +155,38 @@ void FileProviderXPC::start()
return;
}
connection.remoteObjectInterface = [NSXPCInterface interfaceWithProtocol:@protocol(ClientCommunicationProtocol)];
[connection resume];
const id<ClientCommunicationProtocol> clientCommService = (id<ClientCommunicationProtocol>)[connection remoteObjectProxyWithErrorHandler:^(NSError *const error){
qCWarning(lcFileProviderXPC) << "Error getting remote object proxy" << error;
dispatch_group_leave(group);
}];
if (clientCommService == nil) {
qCWarning(lcFileProviderXPC) << "Client communication service is nil";
dispatch_group_leave(group);
return;
}
[connection retain];
[connections addObject:connection];
dispatch_group_leave(group);
}];
}
}
dispatch_group_wait(group, DISPATCH_TIME_FOREVER);
for (NSXPCConnection * const connection in connections) {
Q_ASSERT(connection != nil);
connection.remoteObjectInterface = [NSXPCInterface interfaceWithProtocol:@protocol(ClientCommunicationProtocol)];
connection.interruptionHandler = ^{
qCInfo(lcFileProviderXPC) << "File provider connection interrupted";
};
connection.invalidationHandler = ^{
qCInfo(lcFileProviderXPC) << "File provider connection invalidated";
};
[connection resume];
const id remoteServiceObject = [connection remoteObjectProxyWithErrorHandler:^(NSError *const error){
qCWarning(lcFileProviderXPC) << "Error getting remote object proxy" << error;
}];
NSObject<ClientCommunicationProtocol> *const clientCommService = (NSObject<ClientCommunicationProtocol> *)remoteServiceObject;
if (clientCommService == nil) {
qCWarning(lcFileProviderXPC) << "Client communication service is nil";
continue;
}
[clientCommService retain];
}
}
} // namespace OCC