From e30188d8e401bbd58bdf07bbc1c3633bdb5efe52 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Wed, 22 Feb 2023 20:14:48 +0100 Subject: [PATCH] Handle conversion from input QComboBox index to update channel string more safely Signed-off-by: Claudio Cambra --- src/gui/generalsettings.cpp | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/gui/generalsettings.cpp b/src/gui/generalsettings.cpp index 87217c4f6c..c78eb6ce7d 100644 --- a/src/gui/generalsettings.cpp +++ b/src/gui/generalsettings.cpp @@ -329,21 +329,11 @@ void GeneralSettings::slotUpdateChannelChanged(const QString &translatedChannel) }; const auto updateChannelFromLocalized = [](const int index) { - auto channel = QString{}; - - switch (index) - { - case 0: - channel = QStringLiteral("stable"); - break; - case 1: - channel = QStringLiteral("beta"); - break; - default: - channel = QString{}; + if (index == 1) { + return QStringLiteral("beta"); } - return channel; + return QStringLiteral("stable"); }; const auto channel = updateChannelFromLocalized(_ui->updateChannel->currentIndex());