Constify config file QFileInfo, create directly in if statement

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
This commit is contained in:
Claudio Cambra 2022-12-15 13:24:34 +01:00 committed by Claudio Cambra
parent 0f9ddcddcb
commit d8e8a43cff

View File

@ -172,11 +172,12 @@ bool AccountManager::restoreFromLegacySettings()
legacyCfgFileGrandParentFolder + legacyCfgFileRelativePath};
for (const auto &configFile : legacyLocations) {
if (QFileInfo::exists(configFile)) {
if (const QFileInfo configFileInfo(configFile);
configFileInfo.exists()) {
qCInfo(lcAccountManager) << "Migrate: checking old config " << configFile;
QFileInfo fi(configFile);
if (fi.isReadable()) {
if (configFileInfo.isReadable()) {
std::unique_ptr<QSettings> oCSettings(new QSettings(configFile, QSettings::IniFormat));
if (oCSettings->status() != QSettings::Status::NoError) {
qCInfo(lcAccountManager) << "Error reading legacy configuration file" << oCSettings->status();