From cd2fc994978f7af554b2499674b767c76dcc2d76 Mon Sep 17 00:00:00 2001 From: Camila Ayres Date: Tue, 12 Aug 2025 22:50:59 +0200 Subject: [PATCH] refactor(syncjournaldb): refactor logic before updating the list of columns when removing one. Signed-off-by: Camila Ayres --- src/common/syncjournaldb.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/common/syncjournaldb.cpp b/src/common/syncjournaldb.cpp index dc9b79de66..dc12518479 100644 --- a/src/common/syncjournaldb.cpp +++ b/src/common/syncjournaldb.cpp @@ -895,16 +895,20 @@ bool SyncJournalDb::updateMetadataTableStructure() const auto quotaBytesAvailable = QStringLiteral("quotaBytesAvailable"); const auto defaultCommand = QStringLiteral("DEFAULT -1 NOT NULL"); const auto bigInt = QStringLiteral("BIGINT"); + auto result = false; if (columnExists(quotaBytesUsed) && !hasDefaultValue(quotaBytesUsed)) { - re = removeColumn(quotaBytesUsed); + result = removeColumn(quotaBytesUsed); } if (columnExists(quotaBytesAvailable) && !hasDefaultValue(quotaBytesAvailable)) { - re = removeColumn(quotaBytesAvailable); + result = removeColumn(quotaBytesAvailable); + } + + if (result) { + columns = tableColumns("metadata"); } - columns = tableColumns("metadata"); addColumn(quotaBytesUsed, bigInt, false, defaultCommand); addColumn(quotaBytesAvailable, bigInt, false, defaultCommand); }