mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

ProxyAuthHandler Use QPointer instead of QWeakPointer

Browse Source 
QWeakPointer::data is deprecated.
In this case we should use QPointer
This commit is contained in:
Olivier Goffart 2020-02-05 12:52:58 +01:00 committed by Olivier Goffart
parent 0a8cd2b5f4
commit c779ca604f
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/gui/proxyauthhandler.cpp
View File

@ -83,14 +83,12 @@ void ProxyAuthHandler::handleProxyAuthenticationRequired(
}
// Find the responsible QNAM if possible.
QNetworkAccessManager *sending_qnam = nullptr;
QWeakPointer<QNetworkAccessManager> qnam_alive;
QPointer<QNetworkAccessManager> sending_qnam = nullptr;
if (Account *account = qobject_cast<Account *>(sender())) {
// Since we go into an event loop, it's possible for the account's qnam
// to be destroyed before we get back. We can use this to check for its
// liveness.
qnam_alive = account->sharedNetworkAccessManager();
sending_qnam = qnam_alive.data();
sending_qnam = account->sharedNetworkAccessManager().data();
}
if (!sending_qnam) {
qCWarning(lcProxy) << "Could not get the sending QNAM for" << sender();
@ -128,7 +126,6 @@ void ProxyAuthHandler::handleProxyAuthenticationRequired(
qCInfo(lcProxy) << "got creds for" << _proxy;
authenticator->setUser(_username);
authenticator->setPassword(_password);
sending_qnam = qnam_alive.data();
if (sending_qnam) {
_gaveCredentialsTo.insert(sending_qnam);
connect(sending_qnam, &QObject::destroyed,