diff --git a/src/gui/tray/activitylistmodel.cpp b/src/gui/tray/activitylistmodel.cpp index 9da43924d6..f6c28a85d3 100644 --- a/src/gui/tray/activitylistmodel.cpp +++ b/src/gui/tray/activitylistmodel.cpp @@ -438,18 +438,6 @@ void ActivityListModel::startFetchJob() job->start(); } -void ActivityListModel::setFinalList(const ActivityList &finalList) -{ - _finalList = finalList; - - emit allConflictsChanged(); -} - -const ActivityList &ActivityListModel::finalList() const -{ - return _finalList; -} - int ActivityListModel::currentItem() const { return _currentItem; diff --git a/src/gui/tray/activitylistmodel.h b/src/gui/tray/activitylistmodel.h index 4c0e75e36c..6335e8413f 100644 --- a/src/gui/tray/activitylistmodel.h +++ b/src/gui/tray/activitylistmodel.h @@ -93,9 +93,7 @@ public: Q_ENUM(ErrorType) explicit ActivityListModel(QObject *parent = nullptr); - - explicit ActivityListModel(AccountState *accountState, - QObject *parent = nullptr); + explicit ActivityListModel(AccountState *accountState, QObject *parent = nullptr); [[nodiscard]] QVariant data(const QModelIndex &index, int role) const override; [[nodiscard]] int rowCount(const QModelIndex &parent = QModelIndex()) const override; @@ -103,7 +101,6 @@ public: [[nodiscard]] QHash roleNames() const override; [[nodiscard]] bool canFetchMore(const QModelIndex &) const override; - void fetchMore(const QModelIndex &) override; ActivityList activityList() { return _finalList; } ActivityList errorsList() { return _notificationErrorsLists; } @@ -124,6 +121,8 @@ public: [[nodiscard]] OCC::ActivityList allConflicts() const; public slots: + void fetchMore(const QModelIndex &) override; + void slotRefreshActivity(); void slotRefreshActivityInitial(); void slotRemoveAccount(); @@ -155,21 +154,22 @@ signals: protected: [[nodiscard]] bool currentlyFetching() const; - [[nodiscard]] const ActivityList &finalList() const; // added for unit tests - protected slots: void activitiesReceived(const QJsonDocument &json, int statusCode); void setAndRefreshCurrentlyFetching(bool value); void setDoneFetching(bool value); void setHideOldActivities(bool value); void setDisplayActions(bool value); - void setFinalList(const OCC::ActivityList &finalList); // added for unit tests virtual void startFetchJob(); private slots: void addEntriesToActivityList(const OCC::ActivityList &activityList); void accountStateHasChanged(); + void ingestActivities(const QJsonArray &activities); + void appendMoreActivitiesAvailableEntry(); + void insertOrRemoveDummyFetchingActivity(); + void triggerCaseClashAction(OCC::Activity activity); private: static QVariantList convertLinksToMenuEntries(const Activity &activity); @@ -178,11 +178,6 @@ private: [[nodiscard]] bool canFetchActivities() const; - void ingestActivities(const QJsonArray &activities); - void appendMoreActivitiesAvailableEntry(); - void insertOrRemoveDummyFetchingActivity(); - void triggerCaseClashAction(Activity activity); - void displaySingleConflictDialog(const Activity &activity); void setHasSyncConflicts(bool conflictsFound); @@ -201,8 +196,8 @@ private: bool _displayActions = true; int _currentItem = 0; - int _maxActivities = 100; - int _maxActivitiesDays = 30; + static constexpr int _maxActivities = 100; + static constexpr int _maxActivitiesDays = 30; bool _showMoreActivitiesAvailableEntry = false; QPointer _currentConflictDialog; diff --git a/test/activitylistmodeltestutils.cpp b/test/activitylistmodeltestutils.cpp index 3e8ef27ae8..7527d990e4 100644 --- a/test/activitylistmodeltestutils.cpp +++ b/test/activitylistmodeltestutils.cpp @@ -461,7 +461,7 @@ void TestingALM::startFetchJob() void TestingALM::slotProcessReceivedActivities() { - auto finalListCopy = finalList(); + auto finalListCopy = _finalList; for (int i = _numRowsPrev; i < rowCount(); ++i) { const auto modelIndex = index(i, 0); auto activity = finalListCopy.at(modelIndex.row()); @@ -479,10 +479,10 @@ void TestingALM::slotProcessReceivedActivities() } finalListCopy[modelIndex.row()] = activity; - qDebug() << activity._subject << activity._subjectDisplay; } - setFinalList(finalListCopy); + _finalList = finalListCopy; + emit allConflictsChanged(); setAndRefreshCurrentlyFetching(false); emit activitiesProcessed();