From b0c4f650fe6567b4815dc1f79067ae81d5166290 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Wed, 11 Sep 2024 21:55:27 +0800 Subject: [PATCH] Fix notarisation issues for Sparkle in mac-crafter Signed-off-by: Claudio Cambra --- admin/osx/mac-crafter/Sources/Utils/Codesign.swift | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/admin/osx/mac-crafter/Sources/Utils/Codesign.swift b/admin/osx/mac-crafter/Sources/Utils/Codesign.swift index 027d99c32c..61dfe12376 100644 --- a/admin/osx/mac-crafter/Sources/Utils/Codesign.swift +++ b/admin/osx/mac-crafter/Sources/Utils/Codesign.swift @@ -74,6 +74,16 @@ func codesignClientAppBundle( try recursivelyCodesign(path: "\(clientContentsDir)/PlugIns", identity: codeSignIdentity) try recursivelyCodesign(path: "\(clientContentsDir)/Resources", identity: codeSignIdentity) - print("Code-signing Nextcloud Desktop Client app bundle...") - try codesign(identity: codeSignIdentity, path: clientAppDir) + // Time to fix notarisation issues. + // Multiple components of the app will now have the get-task-allow entitlements. + // We need to strip these out manually. + + print("Code-signing Sparkle autoupdater app (without entitlements)...") + let sparkleFrameworkPath = "\(clientContentsDir)/Frameworks/Sparkle.framework" + try codesign(identity: codeSignIdentity, + path: "\(sparkleFrameworkPath)/Resources/Autoupdate.app/Contents/MacOS/*", + options: "--timestamp --force --verbose=4 --options runtime") + + print("Re-codesigning Sparkle library...") + try codesign(identity: codeSignIdentity, path: "\(sparkleFrameworkPath)/Sparkle") }