From a8c5cbced48254262aa407f484ce9bcbc7a5c856 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Mon, 8 Jul 2024 00:36:28 +0800 Subject: [PATCH] Add logging on error for proxy password saving Signed-off-by: Claudio Cambra --- src/gui/accountmanager.cpp | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gui/accountmanager.cpp b/src/gui/accountmanager.cpp index a0f1e837fa..148fb47d00 100644 --- a/src/gui/accountmanager.cpp +++ b/src/gui/accountmanager.cpp @@ -354,14 +354,19 @@ void AccountManager::saveAccountHelper(Account *acc, QSettings &settings, bool s settings.setValue(networkUploadLimitC, acc->uploadLimit()); settings.setValue(networkDownloadLimitC, acc->downloadLimit()); - const auto proxyPassword = acc->proxyPassword(); const auto proxyPasswordKey = QString(acc->davUser() + networkProxyPasswordKeychainKeySuffixC); - if (proxyPassword.isEmpty()) { + if (const auto proxyPassword = acc->proxyPassword(); proxyPassword.isEmpty()) { const auto job = new KeychainChunk::DeleteJob(proxyPasswordKey, this); Q_ASSERT(job->exec()); + if (job->error() != QKeychain::NoError) { + qCWarning(lcAccountManager) << "Failed to delete proxy password from keychain" << job->errorString(); + } } else { const auto job = new KeychainChunk::WriteJob(acc, proxyPasswordKey, proxyPassword.toUtf8(), this); Q_ASSERT(job->exec()); + if (job->error() != QKeychain::NoError) { + qCWarning(lcAccountManager) << "Failed to save proxy password to keychain" << job->errorString(); + } } if (acc->_credentials) { @@ -509,6 +514,8 @@ AccountPtr AccountManager::loadAccountHelper(QSettings &settings) if (job->error() == QKeychain::NoError) { const auto password = job->textData(); acc->setProxyPassword(password); + } else { + qCWarning(lcAccountManager) << "Failed to read proxy password from keychain" << job->errorString(); } // now the server cert, it is in the general group