diff --git a/src/libsync/owncloudpropagator.h b/src/libsync/owncloudpropagator.h index 9655e1ac49..1ab653d73a 100644 --- a/src/libsync/owncloudpropagator.h +++ b/src/libsync/owncloudpropagator.h @@ -210,8 +210,9 @@ public: virtual ~PropagatorCompositeJob() { - qDeleteAll(_jobsToDo); - qDeleteAll(_runningJobs); + // Don't delete jobs in _jobsToDo and _runningJobs: they have parents + // that will be responsible for cleanup. Deleting them here would risk + // deleting something that has already been deleted by a shared parent. } void appendJob(PropagatorJob *job)