From 6b9950a9a01e97089cd8d05c23fc2e95c092ccb9 Mon Sep 17 00:00:00 2001 From: Daniel Molkentin Date: Thu, 5 Sep 2013 18:41:49 +0200 Subject: [PATCH] Qt5: DBUS is only needed for FDO --- CMakeLists.txt | 15 ++++++++------- cmake/modules/QtVersionAbstraction.cmake | 10 +++++++--- src/CMakeLists.txt | 8 ++++++-- 3 files changed, 21 insertions(+), 12 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 1f14a8e179..1d5bc952ef 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -21,6 +21,14 @@ include(${CMAKE_SOURCE_DIR}/VERSION.cmake) configure_file( ${CMAKE_SOURCE_DIR}/src/mirall/version.h.in "${CMAKE_CURRENT_BINARY_DIR}/src/mirall/version.h" ) include_directories(BEFORE ${CMAKE_CURRENT_BINARY_DIR} "${CMAKE_CURRENT_BINARY_DIR}/src/mirall/") +##### +## handle DBUS for Fdo notifications +if( UNIX AND NOT APPLE ) + add_definitions( -DUSE_FDO_NOTIFICATIONS) + set(WITH_DBUS ON) +endif() +#### + include(GNUInstallDirs) include(DefineInstallationPaths) include(QtVersionAbstraction) @@ -62,13 +70,6 @@ else() endif() ##### -##### -## handle DBUS for Fdo notifications -if( UNIX AND NOT APPLE ) - add_definitions( -DUSE_FDO_NOTIFICATIONS) -endif() -#### - #### find libs #find_package(Qt4 4.7.0 COMPONENTS QtCore QtGui QtXml QtNetwork QtTest QtWebkit REQUIRED ) #if( UNIX AND NOT APPLE ) # Fdo notifications diff --git a/cmake/modules/QtVersionAbstraction.cmake b/cmake/modules/QtVersionAbstraction.cmake index ccc7fd3e93..4134d9cf59 100644 --- a/cmake/modules/QtVersionAbstraction.cmake +++ b/cmake/modules/QtVersionAbstraction.cmake @@ -20,10 +20,14 @@ if( NOT BUILD_WITH_QT4 ) message(STATUS "Using Qt 5!") # We need this to find the paths to qdbusxml2cpp and co - find_package(Qt5DBus REQUIRED) + if (WITH_DBUS) + find_package(Qt5DBus REQUIRED) + include_directories(${Qt5DBus_INCLUDES}) + add_definitions(${Qt5DBus_DEFINITIONS}) + endif (WITH_DBUS) - include_directories("${Qt5Widgets_INCLUDES} ${Qt5DBus_INCLUDES}") - add_definitions(${Qt5Widgets_DEFINITIONS} ${Qt5DBus_DEFINITIONS}) + include_directories(${Qt5Widgets_INCLUDES}) + add_definitions(${Qt5Widgets_DEFINITIONS}) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") # set(CMAKE_CXX_FLAGS "${Qt5Widgets_EXECUTABLE_COMPILE_FLAGS}") diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 2c2d2e04e5..e7bb0c07b4 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -277,6 +277,10 @@ kde4_add_app_icon( ownCloud "${theme_dir}/colored/${APPLICATION_EXECUTABLE}-icon list(APPEND final_src ${ownCloud}) set(ownCloud ${ownCloud_old}) +if (WITH_DBUS) + set(ADDITIONAL_APP_MODULES DBus) +endif(WITH_DBUS) + if(NOT BUILD_OWNCLOUD_OSX_BUNDLE) set(BIN_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin") @@ -295,7 +299,7 @@ endif(NOT WIN32) # add_executable( ${APPLICATION_EXECUTABLE} main.cpp ${final_src}) add_executable( ${APPLICATION_EXECUTABLE} WIN32 main.cpp ${final_src}) - qt5_use_modules(${APPLICATION_EXECUTABLE} Widgets Network Xml DBus WebKitWidgets) + qt5_use_modules(${APPLICATION_EXECUTABLE} Widgets Network Xml WebKitWidgets ${ADDITIONAL_APP_MODULES}) else() set(BIN_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}") include(DeployQt4) @@ -305,7 +309,7 @@ else() # we must add MACOSX_BUNDLE only if building a bundle add_executable( ${APPLICATION_EXECUTABLE} WIN32 MACOSX_BUNDLE main.cpp ${final_src}) - qt5_use_modules(${APPLICATION_EXECUTABLE} Widgets Network Xml DBus WebKitWidgets) + qt5_use_modules(${APPLICATION_EXECUTABLE} Widgets Network Xml WebKitWidgets ${ADDITIONAL_APP_MODULES}) #FIXME: hardcoded path if ( EXISTS ${CSYNC_BINARY_DIR}/modules/ocsync_owncloud.so )