Update detector: make it possible to skip updates.

Fixes issue #588.

src/mirall/mirallconfigfile.cpp

@@ -49,6 +49,23 @@ void MirallConfigFile::setConfDir(const QString &value)
     }
 }
 
+QString MirallConfigFile::seenVersion() const
+{
+    QSettings settings( configFile(), QSettings::IniFormat );
+    settings.setIniCodec( "UTF-8" );
+    settings.beginGroup(QLatin1String("Updater"));
+    return settings.value(QLatin1String("seenVersion")).toString();
+}
+
+void MirallConfigFile::setSeenVersion(const QString &version)
+{
+    QSettings settings( configFile(), QSettings::IniFormat );
+    settings.setIniCodec( "UTF-8" );
+    settings.beginGroup(QLatin1String("Updater"));
+    settings.setValue(QLatin1String("seenVersion"), version);
+    settings.sync();
+}
+
 QString MirallConfigFile::configPath() const
 {
     QString dir = _confDir;

src/mirall/mirallconfigfile.h

@@ -100,6 +100,8 @@ public:
     
     static void setConfDir(const QString &value);
 
+    QString seenVersion() const;
+    void setSeenVersion(const QString &version);
 protected:
     // these classes can only be access from CredentialStore as a friend class.
     QString ownCloudPasswd( const QString& connection = QString() ) const;

src/mirall/occinfo.cpp

@@ -9,6 +9,8 @@
 #include <QtCore/QtDebug>
 #include <QtCore/QFile>
 
+namespace Mirall {
+
 void Owncloudclient::setVersion( const QString &v )
 {
   mVersion = v;
@@ -147,4 +149,4 @@ bool Owncloudclient::writeFile( const QString &filename )
   return true;
 }
 
-
+} // namespace Mirall

src/mirall/occinfo.h

@@ -7,6 +7,8 @@
 #include <QDomElement>
 #include <QtXml/QXmlStreamWriter>
 
+namespace Mirall {
+
 class Owncloudclient
 {
   public:
@@ -31,4 +33,6 @@ class Owncloudclient
     QString mWeb;
 };
 
+} // namespace Mirall
+
 #endif

src/mirall/updatedetector.cpp

@@ -15,6 +15,7 @@
 #include "mirall/updatedetector.h"
 #include "mirall/theme.h"
 #include "mirall/version.h"
+#include "mirall/mirallconfigfile.h"
 #include "mirall/occinfo.h"
 
 #include <QtCore>
@@ -60,6 +61,17 @@ void UpdateDetector::versionCheck( Theme *theme )
     _accessManager->get( QNetworkRequest( url ));
 }
 
+void UpdateDetector::slotOpenUpdateUrl()
+{
+    QDesktopServices::openUrl(ocClient.web());
+}
+
+void UpdateDetector::slotSetVersionSeen()
+{
+    MirallConfigFile cfg;
+    cfg.setSeenVersion(ocClient.version());
+}
+
 QString UpdateDetector::getSystemInfo()
 {
 #ifdef Q_OS_LINUX
@@ -76,6 +88,57 @@ QString UpdateDetector::getSystemInfo()
 #endif
 }
 
+void UpdateDetector::showDialog()
+{
+    // if the version tag is set, there is a newer version.
+    QString ver = QString::fromLatin1("%1.%2.%3")
+            .arg(MIRALL_VERSION_MAJOR).arg(MIRALL_VERSION_MINOR).arg(MIRALL_VERSION_MICRO);
+    QDialog *msgBox = new QDialog;
+
+    QIcon info = msgBox->style()->standardIcon(QStyle::SP_MessageBoxInformation, 0, 0);
+    int iconSize = msgBox->style()->pixelMetric(QStyle::PM_MessageBoxIconSize, 0, 0);
+
+    msgBox->setWindowIcon(info);
+
+    QVBoxLayout *layout = new QVBoxLayout(msgBox);
+    QHBoxLayout *hlayout = new QHBoxLayout;
+    layout->addLayout(hlayout);
+
+    msgBox->setWindowTitle(tr("New Version Available"));
+
+    QLabel *ico = new QLabel;
+    ico->setFixedSize(iconSize, iconSize);
+    ico->setPixmap(info.pixmap(iconSize));
+    QLabel *lbl = new QLabel;
+    QString txt = tr("<p>A new version of the %1 Client is available.</p>"
+                     "<p><b>%2</b> is available for download. The installed version is %3.<p>")
+            .arg(Theme::instance()->appNameGUI()).arg(ocClient.versionstring()).arg(ver);
+
+    lbl->setText(txt);
+    lbl->setTextFormat(Qt::RichText);
+    lbl->setWordWrap(true);
+
+    hlayout->addWidget(ico);
+    hlayout->addWidget(lbl);
+
+    QDialogButtonBox *bb = new QDialogButtonBox;
+    QPushButton *skip = bb->addButton(tr("Skip update"), QDialogButtonBox::ResetRole);
+    QPushButton *reject = bb->addButton(tr("Skip this time"), QDialogButtonBox::AcceptRole);
+    QPushButton  *getupdate = bb->addButton(tr("Get update"), QDialogButtonBox::AcceptRole);
+
+    connect(skip, SIGNAL(clicked()), msgBox, SLOT(reject()));
+    connect(reject, SIGNAL(clicked()), msgBox, SLOT(reject()));
+    connect(getupdate, SIGNAL(clicked()), msgBox, SLOT(accept()));
+
+    connect(skip, SIGNAL(clicked()), SLOT(slotSetVersionSeen()));
+    connect(getupdate, SIGNAL(clicked()), SLOT(slotOpenUpdateUrl()));
+
+    layout->addWidget(bb);
+
+    msgBox->open();
+    msgBox->resize(400, msgBox->sizeHint().height());
+}
+
 void UpdateDetector::slotVersionInfoArrived( QNetworkReply* reply )
 {
     if( reply->error() != QNetworkReply::NoError ) {
@@ -83,10 +146,10 @@ void UpdateDetector::slotVersionInfoArrived( QNetworkReply* reply )
         return;
     }
 
-    QString xml = QString::fromAscii( reply->readAll() );
+    QString xml = QString::fromUtf8(reply->readAll());
 
     bool ok;
-    Owncloudclient ocClient = Owncloudclient::parseString( xml, &ok );
+    ocClient = Owncloudclient::parseString( xml, &ok );
     if( ok ) {
 
     //        Thats how it looks like if a new version is available:
@@ -104,24 +167,11 @@ void UpdateDetector::slotVersionInfoArrived( QNetworkReply* reply )
     //                  <versionstring></versionstring>
     //                  <web></web>
     //                </owncloudclient>
-        if( ocClient.version().isEmpty() ) {
+        MirallConfigFile cfg;
+        if( ocClient.version().isEmpty() || ocClient.version() == cfg.seenVersion() ) {
             qDebug() << "Client is on latest version!";
         } else {
-            // if the version tag is set, there is a newer version.
-            QString ver = QString::fromLatin1("%1.%2.%3")
-                    .arg(MIRALL_VERSION_MAJOR).arg(MIRALL_VERSION_MINOR).arg(MIRALL_VERSION_MICRO);
-            QMessageBox msgBox;
-            msgBox.setTextFormat( Qt::RichText );
-            msgBox.setWindowTitle(tr("Client Version Check"));
-            msgBox.setIcon( QMessageBox::Information );
-            msgBox.setText(tr("<p>A new version of the %1 client is available.").arg(Theme::instance()->appNameGUI()));
-            QString txt = tr("%1 is available. The installed version is %3.<p/><p>For more information see <a href=\"%2\">%2</a></p>")
-                    .arg(ocClient.versionstring()).arg(ocClient.web()).arg(ver);
-
-            msgBox.setInformativeText( txt );
-            msgBox.setStandardButtons( QMessageBox::Ok );
-            msgBox.setDefaultButton( QMessageBox::Ok );
-            msgBox.exec();
+            showDialog();
         }
     } else {
         qDebug() << "Could not parse update information.";

src/mirall/updatedetector.h

@@ -17,6 +17,8 @@
 
 #include <QObject>
 
+#include "mirall/occinfo.h"
+
 class QNetworkAccessManager;
 class QNetworkReply;
 
@@ -35,13 +37,17 @@ signals:
     
 public slots:
 
-protected slots:
+private slots:
+    void slotOpenUpdateUrl();
+    void slotSetVersionSeen();
     void slotVersionInfoArrived( QNetworkReply* );
 
 private:
     QString getSystemInfo();
+    void showDialog();
 
     QNetworkAccessManager *_accessManager;
+    Owncloudclient ocClient;
 };
 
 }