From 6b041b084612ff3759eefc19da85c86318d4053c Mon Sep 17 00:00:00 2001 From: Daniel Molkentin Date: Fri, 20 Jun 2014 10:34:07 +0200 Subject: [PATCH] Fix use-after-free in QNAM propagator This fixes Coverity CID 12929 --- src/mirall/propagator_qnam.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mirall/propagator_qnam.cpp b/src/mirall/propagator_qnam.cpp index 589f6b8246..303034dad0 100644 --- a/src/mirall/propagator_qnam.cpp +++ b/src/mirall/propagator_qnam.cpp @@ -231,10 +231,9 @@ void PropagateUploadFileQNAM::startNextChunk() connect(_job, SIGNAL(uploadProgress(qint64,qint64)), this, SLOT(slotUploadProgress(qint64,qint64))); _job->start(); } else { - delete device; - qDebug() << "ERR: Could not open upload file: " << device->errorString(); done( SyncFileItem::NormalError, device->errorString() ); + delete device; return; } }