From 613fd300212052d04b224ce52b18d06878fcbc2b Mon Sep 17 00:00:00 2001 From: Olivier Goffart Date: Mon, 9 Apr 2018 08:49:56 +0200 Subject: [PATCH] SyncJournalDb::setSelectiveSyncList: Always use a transaction Issue #6431 --- src/common/syncjournaldb.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/common/syncjournaldb.cpp b/src/common/syncjournaldb.cpp index 4fe7523dce..130951b0bd 100644 --- a/src/common/syncjournaldb.cpp +++ b/src/common/syncjournaldb.cpp @@ -1886,6 +1886,8 @@ void SyncJournalDb::setSelectiveSyncList(SyncJournalDb::SelectiveSyncListType ty return; } + startTransaction(); + //first, delete all entries of this type SqlQuery delQuery("DELETE FROM selectivesync WHERE type == ?1", _db); delQuery.bindValue(1, int(type)); @@ -1902,6 +1904,8 @@ void SyncJournalDb::setSelectiveSyncList(SyncJournalDb::SelectiveSyncListType ty qCWarning(lcDb) << "SQL error when inserting into selective sync" << type << path << delQuery.error(); } } + + commitInternal("setSelectiveSyncList"); } void SyncJournalDb::avoidRenamesOnNextSync(const QByteArray &path)