From 4a5ef8f1730c19ffbfad116f2ef213039e2bb48b Mon Sep 17 00:00:00 2001 From: Daniel Molkentin Date: Thu, 12 Jun 2014 10:29:17 +0200 Subject: [PATCH] Fix a possible crash caused by a dangling pointer --- src/wizard/owncloudshibbolethcredspage.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/wizard/owncloudshibbolethcredspage.cpp b/src/wizard/owncloudshibbolethcredspage.cpp index 42b84ea7f0..076d74188d 100644 --- a/src/wizard/owncloudshibbolethcredspage.cpp +++ b/src/wizard/owncloudshibbolethcredspage.cpp @@ -42,10 +42,9 @@ void OwncloudShibbolethCredsPage::setupBrowser() // we need to reset the cookie jar to drop temporary cookies (like the shib cookie) // i.e. if someone presses "back" QNetworkAccessManager *qnam = account->networkAccessManager(); - delete qnam->cookieJar(); CookieJar *jar = new CookieJar; + // Implicitly deletes the old cookie jar, and reparents the jar qnam->setCookieJar(jar); - jar->setParent(0); _browser = new ShibbolethWebView(account); connect(_browser, SIGNAL(shibbolethCookieReceived(const QNetworkCookie&, Account*)),