From 3576fbb2a593138334ef3ecabf846f684795ea9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Sat, 11 Aug 2018 17:47:40 +0200 Subject: [PATCH] Remove unused subclass of QWebEngineView MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- src/gui/wizard/webview.cpp | 25 +------------------------ src/gui/wizard/webview.h | 3 +-- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/src/gui/wizard/webview.cpp b/src/gui/wizard/webview.cpp index e50ef4a13f..15c1f314e8 100644 --- a/src/gui/wizard/webview.cpp +++ b/src/gui/wizard/webview.cpp @@ -37,14 +37,6 @@ Q_SIGNALS: void urlCatched(QString user, QString pass, QString host); }; -class WebEngineView : public QWebEngineView { - Q_OBJECT -public: - WebEngineView(QWidget* parent = 0); - bool acceptNavigationRequest(const QUrl &url, QWebEnginePage::NavigationType type, bool isMainFrame); -}; - - class WebEnginePage : public QWebEnginePage { public: WebEnginePage(QWebEngineProfile *profile, QObject* parent = nullptr); @@ -65,7 +57,7 @@ WebView::WebView(QWidget *parent) { _ui.setupUi(this); - _webview = new WebEngineView(this); + _webview = new QWebEngineView(this); _profile = new QWebEngineProfile(this); _page = new WebEnginePage(_profile); _interceptor = new WebViewPageUrlRequestInterceptor(this); @@ -165,21 +157,6 @@ bool ExternalWebEnginePage::acceptNavigationRequest(const QUrl &url, QWebEngineP return false; } - -WebEngineView::WebEngineView(QWidget* parent) : QWebEngineView (parent) { - -} - -bool WebEngineView::acceptNavigationRequest(const QUrl &url, QWebEnginePage::NavigationType type, bool isMainFrame) -{ - if (type == QWebEnginePage::NavigationTypeLinkClicked) - { - QDesktopServices::openUrl(url); - return false; - } - return true; -} - } #include "webview.moc" diff --git a/src/gui/wizard/webview.h b/src/gui/wizard/webview.h index 01529ef094..1146cd845c 100644 --- a/src/gui/wizard/webview.h +++ b/src/gui/wizard/webview.h @@ -14,7 +14,6 @@ namespace OCC { class WebViewPageUrlRequestInterceptor; class WebViewPageUrlSchemeHandler; -class WebEngineView; class WebEnginePage; class WebView : public QWidget @@ -30,7 +29,7 @@ signals: private: Ui_WebView _ui; - WebEngineView *_webview; + QWebEngineView *_webview; QWebEngineProfile *_profile; WebEnginePage *_page;