mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

ZSync: ensure the temporary file is closed after the download

Browse Source 
Otherwise renaming it to the final file will fail on windows
This commit is contained in:
Olivier Goffart 2018-09-20 16:40:36 +02:00
parent 00984b6738
commit 11cf37ac33
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/libsync/propagatedownload.cpp
View File

@ -881,6 +881,7 @@ void PropagateDownloadFile::contentChecksumComputed(const QByteArray &checksumTy
void PropagateDownloadFile::downloadFinished()
{
ASSERT(!_tmpFile.isOpen());
QString fn = propagator()->getFilePath(_item->_file);
// In case of file name clash, report an error

4
src/libsync/propagatedownloadzsync.cpp
View File

@ -129,6 +129,8 @@ bool GETFileZsyncJob::finished()
}
if (!_hasEmittedFinishedSignal) {
_zr.reset();
_zs.reset(); // ensure the file is closed.
emit finishedSignal();
}
@ -179,6 +181,8 @@ void GETFileZsyncJob::seedFinished(void *zs)
if (_nrange == 0 && _item->_size == quint64(zsync_file_length(_zs.get()))) {
_propagator->reportFileTotal(*_item, 0);
_errorStatus = SyncFileItem::Success;
_zr.reset();
_zs.reset(); // ensure the file is closed.
emit finishedSignal();
return;
}