From 024d01a192db4783d3fb6aaa29b85dc4a54300b1 Mon Sep 17 00:00:00 2001 From: Daniel Molkentin Date: Mon, 8 Jul 2013 01:44:11 +0200 Subject: [PATCH] Cleanly install themed clients next to owncloud on Unix - Renames libowncloudsync for themes - Properly names i18n dir --- src/CMakeLists.txt | 18 ++++++++++-------- src/mirall/application.cpp | 2 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index ada6e37aaa..ddcf9294c7 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -11,6 +11,8 @@ else() set(theme_dir ${CMAKE_CURRENT_SOURCE_DIR}/../theme) endif() +set(synclib_NAME ${APPLICATION_SHORTNAME}sync) + set(mirall_UI mirall/folderwizardsourcepage.ui mirall/folderwizardtargetpage.ui @@ -117,20 +119,20 @@ if(QTKEYCHAIN_FOUND) include_directories(${QTKEYCHAIN_INCLUDE_DIR}) endif() -add_library(owncloudsync SHARED ${libsync_SRCS} ${syncMoc}) -set_target_properties( owncloudsync PROPERTIES +add_library(${synclib_NAME} SHARED ${libsync_SRCS} ${syncMoc}) +set_target_properties( ${synclib_NAME} PROPERTIES VERSION ${VERSION} SOVERSION ${SOVERSION} ) -target_link_libraries(owncloudsync ${libsync_LINK_TARGETS} ) +target_link_libraries(${synclib_NAME} ${libsync_LINK_TARGETS} ) if ( APPLE ) - target_link_libraries(owncloudsync /System/Library/Frameworks/CoreServices.framework) + target_link_libraries(${synclib_NAME} /System/Library/Frameworks/CoreServices.framework) endif() if(NOT BUILD_OWNCLOUD_OSX_BUNDLE) - install(TARGETS owncloudsync + install(TARGETS ${synclib_NAME} RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} @@ -141,7 +143,7 @@ if(NOT BUILD_OWNCLOUD_OSX_BUNDLE) install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${APPLICATION_SHORTNAME}.desktop DESTINATION share/applications ) endif() else() - install(TARGETS owncloudsync DESTINATION ${OWNCLOUD_OSX_BUNDLE}/Contents/MacOS) + install(TARGETS ${synclib_NAME} DESTINATION ${OWNCLOUD_OSX_BUNDLE}/Contents/MacOS) endif() set(mirall_SRCS @@ -222,7 +224,7 @@ if(NOT WIN32) DESTINATION share/icons/hicolor/48x48/apps/ RENAME ${APPLICATION_SHORTNAME}.png) endif(NOT WIN32) - install(FILES ${mirall_I18N} DESTINATION share/mirall/i18n) + install(FILES ${mirall_I18N} DESTINATION share/${APPLICATION_SHORTNAME}/i18n) # we may not add MACOSX_BUNDLE here, if not building one @@ -260,7 +262,7 @@ set_target_properties( ${APPLICATION_EXECUTABLE} PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${BIN_OUTPUT_DIRECTORY} ) target_link_libraries( ${APPLICATION_EXECUTABLE} ${QT_LIBRARIES} ) -target_link_libraries( ${APPLICATION_EXECUTABLE} owncloudsync ) +target_link_libraries( ${APPLICATION_EXECUTABLE} ${synclib_NAME} ) target_link_libraries( ${APPLICATION_EXECUTABLE} ${CSYNC_LIBRARY} ) install(TARGETS ${APPLICATION_EXECUTABLE} diff --git a/src/mirall/application.cpp b/src/mirall/application.cpp index 056eb0aaa7..c993b6f45b 100644 --- a/src/mirall/application.cpp +++ b/src/mirall/application.cpp @@ -79,7 +79,7 @@ QString applicationTrPath() { #ifdef Q_OS_LINUX // FIXME - proper path! - return QLatin1String("/usr/share/mirall/i18n/"); + return QString::fromLatin1("/usr/share/%1/i18n/").arg(Theme::instance()->appName()); #endif #ifdef Q_OS_MAC return QApplication::applicationDirPath()+QLatin1String("/../Resources/Translations"); // path defaults to app dir.