mirrors/naturalcrit
2
0
Fork 0
mirror of https://github.com/naturalcrit/naturalcrit.git synced 2025-10-27 07:29:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove async/await from generateUserToken

Browse Source 
generateAccessToken is fully synchronous and involves no network requests. We can safely remove await.

As a result, no need for try/catch block either, since it cannot fail.
This commit is contained in:
Trevor Buckner 2024-12-26 19:46:33 -05:00
parent b927997e0c
commit 4cb63d78e1
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
server/auth_routes.js
View File

@ -8,14 +8,9 @@ const router = express.Router();
// TODO: MERGE from ACCOUNT.API.JS then probably rename ACCOUNT.API.JS
// Helper function to generate a user token
async function generateUserToken(req, res) {
try {
const accessToken = await token.generateAccessToken(req, res);
return accessToken;
} catch (err) {
console.error('Error generating user token:', err);
throw err;
}
function generateUserToken(req, res) {
const accessToken = token.generateAccessToken(req, res);
return accessToken;
}
// Login API
@ -59,7 +54,6 @@ router.get(
try {
if (!req.user.username) {
}
const jwt = await generateUserToken(req, res);
res.cookie('nc_session', jwt, {
});
res.redirect('/success');
@ -68,6 +62,7 @@ router.get(
res.status(500).send('Internal Server Error');
}
return next(); // Stay on the page if we still need local sign-in
const jwt = generateUserToken(req, res);
maxAge : 1000 * 60 * 60 * 24 * 365, // 1 year
path : '/',
sameSite : 'lax',