From 82f1d37e1edabc51fc96be9abab342a6bf1daa13 Mon Sep 17 00:00:00 2001 From: Stephen Date: Thu, 20 Nov 2025 16:43:29 +0000 Subject: [PATCH] reset --- .../N8nDataTableServer.test.ts | 14 ++------------ .../__snapshots__/Datatable.test.ts.snap | 16 +++++++++++----- .../users/components/SettingsUsersTable.vue | 6 +++--- 3 files changed, 16 insertions(+), 20 deletions(-) diff --git a/packages/frontend/@n8n/design-system/src/components/N8nDataTableServer/N8nDataTableServer.test.ts b/packages/frontend/@n8n/design-system/src/components/N8nDataTableServer/N8nDataTableServer.test.ts index 7be56842b23..8a383312204 100644 --- a/packages/frontend/@n8n/design-system/src/components/N8nDataTableServer/N8nDataTableServer.test.ts +++ b/packages/frontend/@n8n/design-system/src/components/N8nDataTableServer/N8nDataTableServer.test.ts @@ -1,5 +1,5 @@ import userEvent from '@testing-library/user-event'; -import { render, screen, waitFor } from '@testing-library/vue'; +import { render, screen, waitFor, within } from '@testing-library/vue'; import { createComponentRenderer } from '@n8n/design-system/__tests__/render'; @@ -100,17 +100,7 @@ describe('N8nDataTableServer', () => { await userEvent.click(container.querySelector('thead tr th')!); await userEvent.click(container.querySelector('thead tr th')!); - - // Find the page 2 button in the pagination component - const pagination = getByTestId('pagination'); - const pageButtons = pagination.querySelectorAll('.n8n-pagination__button--page'); - const page2Button = Array.from(pageButtons).find( - (btn) => btn.textContent?.trim() === '2', - ) as HTMLElement; - if (!page2Button) { - throw new Error('Page 2 button not found in pagination'); - } - await userEvent.click(page2Button); + await userEvent.click(within(getByTestId('pagination')).getByLabelText('page 2')); expect(emitted('update:options').length).toBe(3); expect(emitted('update:options')[0]).toStrictEqual([ diff --git a/packages/frontend/@n8n/design-system/src/components/N8nDatatable/__snapshots__/Datatable.test.ts.snap b/packages/frontend/@n8n/design-system/src/components/N8nDatatable/__snapshots__/Datatable.test.ts.snap index 68d2e9276d9..a0312811043 100644 --- a/packages/frontend/@n8n/design-system/src/components/N8nDatatable/__snapshots__/Datatable.test.ts.snap +++ b/packages/frontend/@n8n/design-system/src/components/N8nDatatable/__snapshots__/Datatable.test.ts.snap @@ -99,12 +99,18 @@ exports[`components > N8nDatatable > should render correctly 1`] = `
Page size
diff --git a/packages/frontend/editor-ui/src/features/settings/users/components/SettingsUsersTable.vue b/packages/frontend/editor-ui/src/features/settings/users/components/SettingsUsersTable.vue index cbe44a752ae..bea126e4173 100644 --- a/packages/frontend/editor-ui/src/features/settings/users/components/SettingsUsersTable.vue +++ b/packages/frontend/editor-ui/src/features/settings/users/components/SettingsUsersTable.vue @@ -121,9 +121,9 @@ const roleActions = computed>>(() => [ }, ]); -const canUpdateRole = computed((): boolean => - hasPermission(['rbac'], { rbac: { scope: ['user:update', 'user:changeRole'] } }), -); +const canUpdateRole = computed((): boolean => { + return hasPermission(['rbac'], { rbac: { scope: ['user:update', 'user:changeRole'] } }); +}); const filterActions = (user: UsersList['items'][number]) => { if (user.isOwner) return [];