mumble/src/murmur
Robert Adam 52b58de44f
Merge pull request #4196: Add permission for Reset Comment/Avatar
Currently if a user has a "move" permission, they can also reset the comment or avatar of another user as describe in issue #1016. I stumbled into this by accident when I gave a user the move permission to help get new users into the right channels with their friends.

After reviewing the content found in PR #1223 which introduced the reset avatar feature, I found the code that allowed a user to do these resets and changed the required permission from Move to RegisterUser as suggested by @bontibon in the issue thread. As they state, this permission makes more sense than the move permission.

After compiling I found no issues and the changes worked as expected. The one caveat is that if the server has these changes implemented and not the client, (seems daft but this is preferable for me so I don't have to ask my users to change anything) it makes the permissions required to do the reset be move AND registeruser. The client will expect the user to have Move permission and the server will expect the RegisterUser permission, hence then requiring both.

Fixes #1016
2020-06-03 20:49:52 +02:00
..
murmur_grpc src/murmur/murmur_grpc/murmur_grpc.pro: Fix GRPC build 2020-04-05 09:07:24 +02:00
murmur_ice Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
About.cpp Update copyright years in about dialogs for Mumble and Murmur 2020-01-07 03:17:34 +01:00
About.h Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
BonjourServer.cpp Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
BonjourServer.h Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
Cert.cpp Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
DBus.cpp Qt: Adapted to use range-based constructors for lists/vectors/sets for 2020-02-27 15:29:48 +01:00
DBus.h Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
main.cpp src/murmur/main.cpp: Changed description of -v option to reflect better what it's actually about 2020-03-29 19:48:19 +02:00
Messages.cpp ACL:Add new permission for Reset Comment/Avatar in server & client 2020-06-02 23:25:23 +01:00
Meta.cpp src/murmur/Meta.cpp: Negative values of these settings don't make sense. 2020-04-20 15:06:07 -04:00
Meta.h src/murmur: Add autobanSuccessfulConnections flag. 2020-04-20 15:05:04 -04:00
murmur_pch.h Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
Murmur.ice ACL:Add new permission for Reset Comment/Avatar in server & client 2020-06-02 23:25:23 +01:00
murmur.plist Update copyright years in .plist and .rc files 2020-01-07 03:12:11 +01:00
murmur.pro Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
murmur.qrc crlf 2009-03-26 15:07:15 -05:00
murmur.rc Update copyright years in .plist and .rc files 2020-01-07 03:12:11 +01:00
MurmurGRPCImpl.cpp src/murmur/MurmurGRPCImpl.cpp: Use QAtomicInteger::loadRelaxed() instead of QAtomicInteger::load() for Qt >= 5.14 2020-04-20 08:51:21 +02:00
MurmurGRPCImpl.h src/murmur/MurmurGRPCImpl.h: Use namespace grpc instead of grpc_impl 2020-04-20 08:41:14 +02:00
MurmurI.h Feature: Channel Listeners 2020-04-16 09:29:49 +02:00
MurmurIce.cpp Feature: Channel Listeners 2020-04-16 09:29:49 +02:00
MurmurIce.h Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
MurmurIceWrapper.cpp Feature: Channel Listeners 2020-04-16 09:29:49 +02:00
MurmurRPC.proto Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
PBKDF2.cpp Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
PBKDF2.h Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
Register.cpp Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
RPC.cpp Feature: Channel Listeners 2020-04-16 09:29:49 +02:00
Server.cpp src: Allow listener proxies in the same channel the actual user is in 2020-05-04 17:54:16 +02:00
Server.h src/murmur: Fix ChannelListener not hearing shout if no real user is in shouted channel 2020-04-30 09:27:27 +02:00
ServerDB.cpp src/murmur/ServerDB.cpp: Fix DB structure version not getting updated on table update 2020-06-02 08:34:48 +02:00
ServerDB.h src/murmur/ServerDB: Make sure the Database uses proper encoding 2020-05-29 19:21:48 +02:00
ServerUser.cpp src/murmur/ServerUser: Improve implementation of the leaky bucket algorithm 2020-03-21 14:17:41 +01:00
ServerUser.h src/murmur: Fix ChannelListener not hearing shout if no real user is in shouted channel 2020-04-30 09:27:27 +02:00
Tray.cpp Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
Tray.h Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
UnixMurmur.cpp Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00
UnixMurmur.h Auto-update LICENSE.header in source files 2020-01-07 03:09:22 +01:00