mirrors/mumble
2
0
Fork 0
mirror of https://github.com/mumble-voip/mumble.git synced 2025-10-26 11:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
1b26a55ef1
mumble/src
History
Hartmnt 8eb12e9a09 FIX(client): Fix target and permission selection in updateMenuPermissions 
This commit addresses two issues within the 'updateMenuPermissions'
method:
First, the target selection introduced in be7ad39fd was suffering
from the same problem as described in #3090 where selected tree items
were not preferred for determining targets. This issue caused the
chat bar to be erroneously disabled in certain situations, for example
when connecting to a channel with "Text Message" permission disabled
and switching to a different by left-clicking.
The second issue is an oversight in 441d06f6d where the 'Use selected
item as the chat bar target' option was introduced. The permission
check in 'updateMenuPermissions' was not updated to take the new
option into account and therefore always used the selected target
for the permission query independent of the state of the option.

The fix consists of using the unified 'getContextMenuTargets' for
target selection and adding a special case for handling the enabled
state of the chat bar by taking the new option into account.

Fixes #1799
2022-10-17 13:19:53 +00:00
..
benchmarks BUILD: Make benchmarks compile again 2022-09-08 10:47:53 +02:00
crypto MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
mumble FIX(client): Fix target and permission selection in updateMenuPermissions 2022-10-17 13:19:53 +00:00
mumble_exe MAINT: Use separate directory for auxiliary files 2022-09-10 17:28:34 +02:00
murmur FIX(server): Explicitly set parsed timestamps to UTC for rememberchannelduration 2022-10-08 11:24:30 +00:00
tests MAINT: Update copyright notice to 2022 2022-10-02 12:08:50 +02:00
ACL.cpp DOCS: Fix typos 2022-02-06 18:27:12 +01:00
ACL.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Ban.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Ban.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ByteSwap.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Channel.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Channel.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ChannelListenerManager.cpp FEAT: Make channel listeners persistent on server 2022-09-12 12:42:01 +02:00
ChannelListenerManager.h FEAT: Make channel listeners persistent on server 2022-09-12 12:42:01 +02:00
CMakeLists.txt BUILD(cmake): Use EXCLUDE_FROM_ALL for 3rdparty subdirs 2022-09-10 17:28:34 +02:00
Connection.cpp CHANGE: Use Protobuf for UDP messages 2022-03-27 09:49:58 +02:00
Connection.h CHANGE: Use Protobuf for UDP messages 2022-03-27 09:49:58 +02:00
CryptState.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
EnvUtils.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
EnvUtils.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
FFDHE.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
FFDHE.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Group.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Group.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
HostAddress.cpp FEAT(client, ui): separate ipv4 and ipv6 in ServerItem tooltip 2022-06-05 20:03:35 +02:00
HostAddress.h FEAT(client, ui): separate ipv4 and ipv6 in ServerItem tooltip 2022-06-05 20:03:35 +02:00
HTMLFilter.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
HTMLFilter.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
License.cpp BUILD: Auto-generate licenses.h 2022-09-10 17:28:33 +02:00
License.h BUILD: Auto-generate licenses.h 2022-09-10 17:28:33 +02:00
LogEmitter.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
LogEmitter.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Mumble.proto FEAT: Make channel listeners persistent on server 2022-09-12 12:42:01 +02:00
MumbleConstants.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
MumbleProtocol.cpp FIX(client, server): Fix patch versions > 255 2022-09-08 10:45:47 +02:00
MumbleProtocol.h FIX(client, server): Fix patch versions > 255 2022-09-08 10:45:47 +02:00
MumbleUDP.proto FIX(client, server): Fix patch versions > 255 2022-09-08 10:45:47 +02:00
Net.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Net.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
OSInfo.cpp FIX(client, server): Fix patch versions > 255 2022-09-08 10:45:47 +02:00
OSInfo.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
PacketDataStream.h CHANGE: Use Protobuf for UDP messages 2022-03-27 09:49:58 +02:00
PasswordGenerator.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
PasswordGenerator.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
PlatformCheck.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
PlatformCheck.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ProcessResolver.cpp BUILD(client): Plugin framework: Use correct struct kinfo_proc members on NetBSD/OpenBSD 2022-01-11 22:32:15 +01:00
ProcessResolver.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ProtoUtils.cpp FIX(client, server): Fix patch versions > 255 2022-09-08 10:45:47 +02:00
ProtoUtils.h FIX(client, server): Fix patch versions > 255 2022-09-08 10:45:47 +02:00
QtUtils.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
QtUtils.h FEAT(client): Add User and Listener volume slider to context menus 2022-08-17 19:08:04 +00:00
SelfSignedCertificate.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
SelfSignedCertificate.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ServerAddress.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ServerAddress.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ServerResolver.cpp FIX(client): properly verify certificates when SRV records are used 2022-07-20 18:48:12 +02:00
ServerResolver.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ServerResolverRecord.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
ServerResolverRecord.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
SignalCurry.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
SSL.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
SSL.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
SSLLocks.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
SSLLocks.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Timer.cpp BUILD(client,server): Include time.h instead of sys/time.h 2022-02-04 20:06:09 +01:00
Timer.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
UnresolvedServerAddress.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
UnresolvedServerAddress.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
User.cpp MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
User.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Utils.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00
Version.cpp FIX(client, server): Fix patch versions > 255 2022-09-08 10:45:47 +02:00
Version.h FIX(client, server): Fix patch versions > 255 2022-09-08 10:45:47 +02:00
VolumeAdjustment.cpp FEAT(client): Add possibility to change notification volume 2022-08-01 12:27:08 +02:00
VolumeAdjustment.h FEAT(client): Add possibility to change notification volume 2022-08-01 12:27:08 +02:00
win.h MAINT: Update copyright to 2022 2022-01-04 20:17:33 +01:00