Commit Graph

222 Commits

Author SHA1 Message Date
Mikkel Krautz
f03b74db2d Add mutex for csCrypt usage in Murmur. 2016-06-24 00:03:11 +02:00
Mikkel Krautz
f260bd1913 Implement correct write locking for addChannel/removeChannel/link/unlink. 2016-06-24 00:03:11 +02:00
Mikkel Krautz
f66b0d34c8 Rename qrwlUsers to qrwlVoiceThread. 2016-06-24 00:03:11 +02:00
spede
5d1a56e6e8 Add logging for ban removals/changes.
Fixes mumble-voip/mumble#1996
2016-05-19 00:31:42 +02:00
Mikkel Krautz
54c28d3ee1 src/murmur: update to use LICENSE.header. 2016-05-10 22:42:02 +02:00
Mikkel Krautz
a107fb3d71 grpc: fix formatting of textMessageFilter result handling. 2016-05-08 16:45:52 +02:00
Tim Cooper
805c0477c1 grpc: implement TextMessageFilter 2016-05-08 16:45:52 +02:00
Mikkel Krautz
c22393e9db Messages, Murmur.ice: make username checking case insensitive throughout Murmur.
The database query for looking up users in ServerDB has always been
case insensitive.

This commit makes the "duplicate user"-check in Messages.cpp case
insensitive as well.

Furthermore, this commit updates the documentation for the authenticate()
callback in Murmur.ice to document that authenticators should strive to
make usernames case insensitive.

Fixes mumble-voip/mumble#1078
2016-01-05 00:00:29 +01:00
Tim Cooper
fea39f2008 Respect maximum channel user limits when joining server
Fixes mumble-voip/mumble#1930
2015-11-28 10:17:22 +01:00
Tim Cooper
0b0c074dda Allow users with Write permission to bypass channel user limits
Fixes mumble-voip/mumble#1920
2015-11-24 19:30:02 +01:00
Tim Cooper
c0879e57bf Allow creating channel with a set maximum number of users
Fixes mumble-voip/mumble#1913
2015-11-22 17:31:21 +01:00
Tim Cooper
84b1bcecef Add per-channel user limit 2015-11-22 14:17:39 +01:00
Tim Cooper
07a142d1b8 Include actor when performing a user rename 2015-11-22 14:13:08 +01:00
Tim Cooper
4862897a5b Add maximum number of server users to control channel protocol 2015-11-16 22:35:40 +01:00
Stefan Hacker
68205b9311 Fix remaining warnings in murmur code
Fixes remaining unused function, shadow and cast warnings
in murmur code.
2015-10-27 00:01:13 +01:00
Tim Cooper
9ba92b584e Add user friendly UserRemove message when disconnecting a ghost user.
This commit adds a user friendly UserRemove message
when a username is reused from the same IP-address.
2015-03-18 20:16:43 +01:00
Iain Georgeson
97cf80de70 Log IP address on failed login
* Show the IP address of the rejected connection in the mumble-server log.
** Allows use in ban-software which scans logs (requested for fail2ban).
*** Note that the address format will differ with activated IP obfuscation.
* Applied patch from https://sourceforge.net/p/mumble/bugs/861/
which implements the FR #1303 and fixes debian bug 627139 [1]
* This patch was already automatically applied to our Ubuntu PPA builds [2]

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=627139
[2] https://github.com/mumble-voip/mumble-ubuntu-ppa/blob/master/patches/02-reject-with-ip-in-log.diff
2014-07-13 22:53:51 +02:00
Tim Cooper
52d19ac3ae Allow admins to clear user avatars/textures. 2014-04-15 19:59:20 +02:00
Tim Cooper
02ddd91481 Allow user renames via UserList without requiring a reconnect.
This commit also adds a check to Murmur's UserState handler that
discards UserState messages that come from users. Only Murmur
can send UserStates with a name.

The client-facing way of renaming is through the UserList. When
a user is renamed, Murmur will broadcast a UserState with the
given session and name to perform a live rename operation.
2014-04-13 22:04:51 +02:00
Kissaki
ef8b3b99f5 Userlist improvements: Use QDateTime.
* Use QDateTime wherever possible.
* Code refactoring
2013-06-28 23:57:23 +02:00
Kissaki
f6ceaf9d2b Improved Userlist: Refacs.
* Use boost::optional for explicit no data
* Move logic into method
mapping logic into protoUserToUserInfo
2013-06-28 21:31:59 +02:00
Kissaki
0af571b019 Filtered Userlist: Refactoring. C
* Move logic into methods (in UserEdit)
* Minor formatting
* Fix memory leak (delete ueli if not passed to QTreeWidget
* Show filters and stuff when lastchantreestring is not empty, as that should always have something
(It even has something when no data comes from server though.)
2013-06-28 21:30:15 +02:00
Kissaki
2a7e78940d Userlist improv.: Fix indent. Use iterator again.
* Plus a string fix.
2013-06-23 22:05:01 +02:00
Zuko
b3aac5e0f5 UserList improvements 2013-06-23 20:38:58 +02:00
Henry Fallon
88d41e10f5 FR #1096 by Henry Fallon: Corrections to string, Add missing comments in Murmur.ice and add Missing MainWindow::msgReject in Client 2013-06-04 22:38:46 +02:00
Henry Fallon
7cff8ca5d8 Introduce auth rejection type AuthenticatorFail
* introduce AuthenticatorFail into Reject proto
* use authenticator returncode -3 as AuthenticatorFail
2013-06-04 22:37:59 +02:00
Kissaki
9bd10b0001 refacs; initialization, var-scope reduction, replace c-style casts, rm unused
* DBus.h, AudioOutputSpeech.cpp: initialize uninitialized members,
* d3d10.cpp: actually use assigned results for a dbg output
* lib.cpp, link.cpp: c-style to c++-style casts
* SpeexMark.cpp, ResampMark.cpp: rm unused var
* AGC.cpp, ResampMark.cpp:
rm unused var (ineffective return statement after prior return;
thus removing unused code - but someone check if sth. was missed there)
2012-10-24 19:24:33 +02:00
Stefan Hacker
145d9f96f5 Introduce channel nesting limit (default=10).
Add NestingLimitException to Ice Interface and introduce a new NestingLimit PermissionDenied type.
Addresses #3566322 "ServerDB::deleteServer crashes master"
2012-09-18 17:50:07 +02:00
Stefan Hacker
aa580f392c Trigger codec re-negotiation also on user disconnect and when opusthreshold is set.
- Call recheckCodecVersion on AuthenticatedClient disconnect.
- Make every recheckCodecVersions() call switching to Opus send a message to users only supporting CELT.
2012-08-06 02:29:20 +02:00
Benjamin Jemlich
7ec4f6a67c Murmur: Add codec warnings and ignore non-Opus packets if Opus is enabled
Also includes the CELT warning for "broken" clients by Nicos Gollan.
2012-06-08 23:55:56 +02:00
Benjamin Jemlich
f0c16f33ba Murmur: add Opus threshold option 2012-06-08 08:44:02 +02:00
Benjamin Jemlich
84ed2eb84f Murmur: Remove unused DBus.h includes 2012-05-31 13:00:39 +02:00
Benjamin Jemlich
52e27ef37f Murmur: Disallow mute/deafen status changes in temporary channels 2012-05-16 12:15:46 +02:00
Benjamin Jemlich
2b9e094ab2 Allow using ChanACL::hasPermission without a cache 2012-01-08 12:59:47 +01:00
Benjamin Jemlich
07737a314c Fix include guards and PCH includes 2011-11-09 00:12:10 +01:00
Thorvald Natvig
86fc793a5d Opus codec negotiation (server) 2011-11-06 19:00:33 -08:00
Benjamin Jemlich
089b23d977 Fix ghost disconnect removing permissions (#3423985)
Returning a list of groups using an authenticator added
temporary group membership for the user id only. Those are
removed when we're disconnecting an old user using the same
user id. Adding the session id to the group should fix the
problem.

This won't work if someone uses verifyPassword to set the
permissions (which is an undocumented implementation detail
anyway).
2011-10-23 09:30:02 +02:00
Stefan Hacker
f0c2bfd16a Replace some manual version conversions with appropriate MumbleVersion calls. 2011-07-31 02:57:29 +02:00
Benjamin Jemlich
f7d7b99b56 Merge ContextActionRemove and ContextActionAdd and rename it to ContextActionModify 2011-05-14 09:29:47 +02:00
Stefan Hacker
c98e3eaf8b Fix: Stale custom context menu entries (#3301658)
Added a new ContextActionRemove protobuf message type triggering the clientside removal of a context menu entry. Since the server only remembers the action identifier and doesn't have a notion of where it is applied to on the client it is only possible to remove all entries for an identifier at the same time at this point. The removal is triggered when overriding a new handler (clientside visibility might have changed), remove a handler and in error conditions.
2011-05-13 18:10:22 +02:00
Stefan Hacker
4d50beb0a6 Improve error message when connecting with an invalid password/certificate to a registered account 2011-04-17 21:26:47 +02:00
Jamie Fraser
bd690db645 Fixed up Otto's patch (#2911421), mostly style stuff. Changed int -> uint and iterators to foreach() 2011-04-08 02:38:32 +02:00
Otto Allmendinger
1d832d56ff Text Message Callback with Ice 2011-04-08 02:38:31 +02:00
Thorvald Natvig
94967abfd8 Suggest Config 2011-03-25 19:54:26 -07:00
Thorvald Natvig
f3437a6ba7 Update copyright year ranges of dev team. 2011-03-18 05:52:51 +01:00
Benjamin Jemlich
ecf3bddc53 Save last channel on user registration 2010-12-24 00:55:45 +01:00
Stefan Hacker
b8a2745ce7 Fix two signed|unsigned comparison warnings 2010-12-03 14:19:26 +01:00
Benjamin Jemlich
39039c2798 Disallow RequestBlob for unauthenticated users 2010-11-29 01:06:45 +01:00
Benjamin Jemlich
df7dc3a889 Don't crash if someone tries to add an ACE for an unknown user id 2010-11-25 02:27:18 +01:00
Stefan Hacker
ce79583536 Fix easter time and a compiler warning 2010-10-16 19:55:40 +02:00