Removes invalid characters (UTF-16 BOM) at the start of line 6.
The profiledir variable is set properly again. Fixing the vcpkg directory being created in the root of the system directory.
Original error message below:
$profiledir : The term '$profiledir' is not recognized as the name of a cmdlet, function, script file, or
operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try
again.
At C:\Dev\Git\mumble\scripts\vcpkg\get_mumble_dependencies.ps1:6 char:1
+ $profiledir = $Env:USERPROFILE
+ ~~~~~~~~~~~~~~
+ CategoryInfo : ObjectNotFound: ($profiledir:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException
Apparently the first commit (59ae429972)
did not include all files.
Furthermore the used script tended to produce funny results in certain
cases. This has been fixed and as a result thereof a few more changes
were made in this second run.
In this mode the sametext heuristic is disabled which _should_ fix the
issue of the Weblate PR's CI failing because of Weblate not applying
such heuristics.
This commit adds a few more grouping rules to the generateChangelog.py
script which should further reduce the manual labor needed to create
changelogs.
The assumptions about the format of the merge commit message were rather
strict and thus slight deviations would cause the script to fail.
Therefore the script got overhauled and is now using a (hopefully) more
versatile RegEx to do the job.
The bash script is not platform independent. The python script is.
I invested way too much time trying to run the sh script on WSL (Windows Subsystem for Linux), installing Qt packages, but in the end still failing.
I also implemented a bat script calling lupdate with the same parameters as the sh script, but having one platform independent script is preferable to having two separate scripts for the same activity.
The python script will call lupdate to update the ts files like the sh script did,
and commit the changes if any were made.
Furthermore it checks that the ts files have no local changes before running,
and after updating reset the git index, add commit the files.
The reset operation is added so only the ts files are being committed.
Contrary to the previous script this one disables all heuristics so those can be applied as separate changes, so they will be visible.
Our previous workflow was using `scripts/updatetranslations.sh` to update `src/mumble/mumble_en.ts` only.
We then depended on Transifex to take over text source changes from this file to translation files.
This lead to committed changes being a mix of both translation source changes as well as translations.
This made the diffs unnecessarily big, and hard to review as two concerns are intermixed.
Weblate supports this style of updating as well. It calls this style 'monolingual', although that concept is intermixed with, or designed for files that do not contain translation source text (which ours do).
One file is used as a source, and another contains the translation strings.
Seemingly Qt calls this approach text-by-ID, and the translation strings are looked up by the ID, which in our case are the translation source strings.
This seems like a misuse of the concept.
The monolingual vs bilingual translation files issue/discrepancy is not handled in this change.
---
From now on we update all ts files so an update to the translation files with this script leads to an update in all translation files
rather than only the 'mumble_en.ts' reference file.
This approach will make translation change commits and PRs afterwards isolated to translation changes, and thus a lot smaller and easier to review.
There will no longer be an invisible, implicit difference between the committed ts file and the current program state = the translation source.
Text with plural forms (a %n parameter and singular(s) qualifier) lead to special plural handling.
Different locales can have varying words depending on the number; mostly partially differently between 0, 1 and more.
English texts can have simple 'word(s)' text which will be transformed to '0 word', '1 word', '2 words', '3 words' and so on respectively.
Other languages may not have this mechanism, and the ts files are prepared with `<numerus>` elements within the `<translation>` elements.
These seem to be for specifying the varying plural forms manually.
This seems to be an automatism by lupdate.
When updating our current ts files it warns about multiple instances of the number of `numerus` elements not matching the number of plural forms in the locale the file is for.
Whatever the original hack/fix was for (#1195, the linked Transifex topic no longer works),
it seems very problematic.
Previously we only updated mumble_en.ts, and then depended on Transifex to update the contents of the other ts files when translations are changed.
This led to source and translation changes being intermixed in the change commit.
This change drops the 'numerus' element duplication.
This is in preparation for in the future updating translation sources on all ts files, where this fixup could be technically incorrect and problematic as a result.
As well as to drop this hack which seems like an awful, misleading and technically incorrect workaround for Transifex bugs or side effects in it’s transformation of source ts file to translation ts files.
The 'numerus' tag is not documented in Qt documentation with any information.
https://doc.qt.io/qt-5/i18n-source-translation.html#handling-plurals
The script iterates through (almost) all files within the Mumble
repository and updates the copyright notice in them. If source files
don't contain such a notice yet, it can optionally add one in.
The script asks git when the file was first added to the git index and
uses that year as the starting year for the copyright notice. The end
year is always set to be the current year at the time the script is run.
The option replaces "--project" and allows to specify the desired string format:
- "full": The default. Prints version + suffix (e.g. "1.4.0~2021-02-14~g973cee211~snapshot").
- "version": Only prints the version (e.g. "1.4.0").
- "suffix": Only prints the suffix (e.g. "~2021-02-14~g973cee211~snapshot").
The main reason for implementing this new option is the suffix-only output.
It will be passed to CMake in a future commit, for better filename control.
This commit removes the tag logic from the script.
Its purpose was to set the name of the tag associated to the latest version as version.
It was working as expected, however in some instances we don't want the script to take the tag into account.
For example, we had to rebuild the first 1.4.0 snapshot as the version was accidentally set to 1.4.0-snapshot1.
As replacement, the "--revision" and "--type" options are implemened.
They allow to explicitly set the release type and its revision, when applicable.
Assuming the revision is set to 1 (default value), the output is currently as follows:
Type set to "snapshot": 1.4.0~2021-02-14~g973cee211~snapshot
Type set to "beta": 1.4.0-beta1
Type set to "rc": 1.4.0-rc1
Type set to "stable": 1.4.0
The following changes were performed:
- Modify function to accept a string array param
- Add mdnsresponder to the packages array
- Remove individual package installs affected by previous --clean-after-build issue
- Remove iterator that installs packages independently
- Remove unneeded double quotes for variables
- Remove opus as it is supplied via submodule
The following changes were performed:
- Modify function to accept a string array param
- Add mdnsresponder to the packages array
- Remove individual package installs affected by previous --clean-after-build issue
- Remove iterator that installs packages independently
- Remove unneeded double quotes for variables
Fixes#4674
The option tells the script to print only the project version, i.e. "1.4.0".
This commit also makes the "--newline" argument an option and changes some text, for consistency.
The build number can be specified through the new "BUILD_NUMBER" variable.
This change is very important on Windows, for two reasons:
- It allows to easily identify binaries simply by looking at their version.
More specifically, we can guess what build they're part of.
- Right now snapshots can not be updated without uninstalling first, because the version is the same (i.e. 1.4.0).
By increasing the 4th digit of the version for every build we can solve the issue.
This commit also takes care of renaming a few variables so that they're consistent and also clearer.
For example, "version" is now "RELEASE_ID".
- Remove CPack and previous WiX installer projects and sources
- Add toolset for WixSharp to facilitate client and server builds
individually or collectively.
- Add multilanguage build with packaging=ON and translations=ON, and
standard build with packaging=ON. Builds are also aware of client and
server option settings.
- Add correct LICENSE to installer
Fixes: #4488
WixSharp: https://github.com/oleg-shilo/wixsharp
Remove CPack and previous WiX installer projects and sources
Add toolset and for WixSharp to facilitate client and server builds
individually or collectively.
Add multilanguage build with packaging=ON and translations=ON, and
standard build with packaging=ON. Builds are also aware of client and
server option settings.
Add correct LICENSE to installer
As things are now, 'systemctl start murmur' hangs and eventually times
out.
The problem is that in the unit file, both Type=forking and
PIDFile=/run/murmur/murmur.pid are specified. In this scenario systemd
will wait for the PID file to appear. However, it will never appear
there, as murmur does setuid on its own before writing the pid file,
and thus lacks the rights to write to /run, and even if it had the rights,
it doesn't try to create a missing directory anyway.
Switch to Type=exec and foreground mode to fix this. systemd services
don't really need forking behaviour anyway, and in fact handling
forking servers requires some extra hoops to jump through on the
systemd side.
This change also makes murmur (when run with murmur.service) to log
to the systemd journal instead of log files.
Although the unit file has been broken for a long time, Debian-based
distros still use the /etc/init.d/mumble-server wrapped with
systemd-sysv-generator, and haven't noticed the problem.
The new tool provided at https://github.com/probonopd/go-appimage/blob/master/src/appimagetool doesn't have the restriction of having to be run on the latest still supported Ubuntu version. Thus this allows us to upgrade our Linux CI on Azure to Bionic.
Note however that the AppImage produced this way doesn't seem to be working.
Updated the mumble.desktop and mumble.appdata.xml files to meet the most
recent information and also meet the more modern standards that have
been established.
They now pass validation by appstreamcli.
