From fac930b32773f754cfceb6430fd6f9f7dbf7de5d Mon Sep 17 00:00:00 2001
From: Stefan Hacker <dd0t@users.sourceforge.net>
Date: Fri, 5 Jun 2015 16:24:33 +0200
Subject: [PATCH] Suppress warnings in 3rd party codec builds

This patch disables all warnings in celt and opus builds.
They were very noise and drowned out the warnings in our
code to the point where no one even bothered looking at them.
As we don't inspect those warnings and won't attempt to fix
them anytime soon they are not useful to us.

Added third-party-warnings qmake CONFIG option to optionally
re-enable warnings for those (and in the future other) 3rd
part builds.
---
 3rdparty/celt-0.11.0-build/celt-0.11.0-build.pro | 9 +++++++--
 3rdparty/celt-0.7.0-build/celt-0.7.0-build.pro   | 7 +++++++
 3rdparty/opus-build/opus-build.pro               | 9 +++++++--
 3 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/3rdparty/celt-0.11.0-build/celt-0.11.0-build.pro b/3rdparty/celt-0.11.0-build/celt-0.11.0-build.pro
index 33a6b77bd..ee52e1f70 100644
--- a/3rdparty/celt-0.11.0-build/celt-0.11.0-build.pro
+++ b/3rdparty/celt-0.11.0-build/celt-0.11.0-build.pro
@@ -13,8 +13,6 @@ VERSION=$$replace(VERSION,celt-,)
 TEMPLATE = lib
 CONFIG -= qt
 CONFIG += debug_and_release
-CONFIG -= warn_on
-CONFIG += warn_off
 CONFIG += no_include_pwd
 VPATH	= ../$$SOURCEDIR/libcelt
 TARGET = celt0
@@ -27,6 +25,13 @@ CONFIG(static) {
 	CONFIG += shared
 }
 
+!CONFIG(third-party-warnings) {
+	# We ignore warnings in third party builds. We won't actually look
+	# at them and they clutter out our warnings.
+	CONFIG -= warn_on
+	CONFIG += warn_off
+}
+
 QMAKE_CFLAGS -= -fPIE -pie
 
 win32 {
diff --git a/3rdparty/celt-0.7.0-build/celt-0.7.0-build.pro b/3rdparty/celt-0.7.0-build/celt-0.7.0-build.pro
index 4001eaf22..e7fd20080 100644
--- a/3rdparty/celt-0.7.0-build/celt-0.7.0-build.pro
+++ b/3rdparty/celt-0.7.0-build/celt-0.7.0-build.pro
@@ -32,6 +32,13 @@ CONFIG(sbcelt) {
 	}
 }
 
+!CONFIG(third-party-warnings) {
+	# We ignore warnings in third party builds. We won't actually look
+	# at them and they clutter out our warnings.
+	CONFIG -= warn_on
+	CONFIG += warn_off
+}
+
 QMAKE_CFLAGS -= -fPIE -pie
 
 win32 {
diff --git a/3rdparty/opus-build/opus-build.pro b/3rdparty/opus-build/opus-build.pro
index 6e485304f..c20abac36 100644
--- a/3rdparty/opus-build/opus-build.pro
+++ b/3rdparty/opus-build/opus-build.pro
@@ -15,13 +15,18 @@ SOURCEDIR=$$replace(BUILDDIR,-build,-src)
 TEMPLATE = lib
 CONFIG -= qt
 CONFIG += debug_and_release
-#CONFIG -= warn_on
-#CONFIG += warn_off
 CONFIG += no_include_pwd
 VPATH	= ../$$SOURCEDIR
 TARGET = opus
 DEFINES += HAVE_CONFIG_H
 
+!CONFIG(third-party-warnings) {
+	# We ignore warnings in third party builds. We won't actually look
+	# at them and they clutter out our warnings.
+	CONFIG -= warn_on
+	CONFIG += warn_off
+}
+
 QMAKE_CFLAGS -= -fPIE -pie
 
 win32 {