diff --git a/src/mumble/ConnectDialog.cpp b/src/mumble/ConnectDialog.cpp index 1d88fcc0e..b9082b2d3 100644 --- a/src/mumble/ConnectDialog.cpp +++ b/src/mumble/ConnectDialog.cpp @@ -486,7 +486,7 @@ QVariant ServerItem::data(int column, int role) const { arg(boost::accumulators::extended_p_square(* asQuantile)[2] / 1000., 0, 'f', 2)) + QString::fromLatin1("
Protocol %1.%2.%3.
").arg(QString::number((version >> 16) & 0xFF), - QString::number((version >> 8) & 0xFF), - QString::number(version & 0xFF)); + QString qsVersion=tr("Protocol %1.
").arg(MumbleVersion::toString(g.sh->uiVersion)); if (g.sh->qsRelease.isEmpty() || g.sh->qsOS.isEmpty() || g.sh->qsOSVersion.isEmpty()) { qsVersion.append(tr("No build information or OS version available.
")); diff --git a/src/mumble/UserInformation.cpp b/src/mumble/UserInformation.cpp index b5f7c86a2..4be599717 100644 --- a/src/mumble/UserInformation.cpp +++ b/src/mumble/UserInformation.cpp @@ -151,12 +151,8 @@ void UserInformation::update(const MumbleProto::UserStats &msg) { showcon = true; const MumbleProto::Version &mpv = msg.version(); - unsigned int v = mpv.version(); - unsigned int major = (v >> 16) & 0xFFFF; - unsigned int minor = (v >> 8) & 0xFF; - unsigned int patch = (v & 0xFF); - qlVersion->setText(tr("%1.%2.%3 (%4)").arg(major).arg(minor).arg(patch).arg(u8(mpv.release()))); + qlVersion->setText(tr("%1 (%2)").arg(MumbleVersion::toString(mpv.version())).arg(u8(mpv.release()))); qlOS->setText(tr("%1 (%2)").arg(u8(mpv.os())).arg(u8(mpv.os_version()))); } if (msg.celt_versions_size() > 0) { diff --git a/src/murmur/Messages.cpp b/src/murmur/Messages.cpp index c0a69af59..db32a10f0 100644 --- a/src/murmur/Messages.cpp +++ b/src/murmur/Messages.cpp @@ -39,6 +39,7 @@ #include "Server.h" #include "ServerUser.h" #include "DBus.h" +#include "Version.h" #define MSG_SETUP(st) \ if (uSource->sState != st) { \ @@ -1398,7 +1399,8 @@ void Server::msgVersion(ServerUser *uSource, MumbleProto::Version &msg) { if (msg.has_os_version()) uSource->qsOSVersion = u8(msg.os_version()); } - log(uSource, QString("Client version %1.%2.%3 (%4: %5)").arg(uSource->uiVersion >> 16).arg((uSource->uiVersion >> 8) & 0xff).arg(uSource->uiVersion & 0xFF).arg(uSource->qsOS).arg(uSource->qsRelease)); + + log(uSource, QString("Client version %1 (%2: %3)").arg(MumbleVersion::toString(uSource->uiVersion)).arg(uSource->qsOS).arg(uSource->qsRelease)); } void Server::msgUserList(ServerUser *uSource, MumbleProto::UserList &msg) {