mirrors/mumble
2
0
Fork 0
mirror of https://github.com/mumble-voip/mumble.git synced 2025-10-26 11:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX(client): Do not spam log when adjusting volume of clients without certificate

Browse Source 
In #5776 the local volume adjustment sliders were moved into the user context menu.
A log warning message appears, if you adjust the volume of a client without
certificate.
Due to a combination of Qt's buggy MouseWheel events and the oversight that
volume changes to the DB happen much more frequently with that change, the
log warning messages are spammed way to often now in that case.

This commit moves the log warning message explicitly into a separate slot on
slider release. Note: We "lose" the warning message for other input methods that
are not "releasing the slider", but given the fact that certificates are pretty
prevalent now and dragging the slider is likely the most often used input method,
this will likely affect a very little amount of users.

Fixes #6462
This commit is contained in:
Hartmnt 2024-06-30 12:46:32 +00:00
parent 2a8c6f3906
commit efe91b979d
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/mumble/UserLocalVolumeSlider.cpp
View File

@ -11,6 +11,7 @@
#include "Global.h"
UserLocalVolumeSlider::UserLocalVolumeSlider(QWidget *parent) : VolumeSliderWidgetAction(parent) {
connect(m_volumeSlider, &QSlider::sliderReleased, this, &UserLocalVolumeSlider::on_VolumeSlider_sliderReleased);
}
void UserLocalVolumeSlider::setUser(unsigned int sessionId) {
@ -40,10 +41,15 @@ void UserLocalVolumeSlider::on_VolumeSlider_changeCompleted() {
if (user) {
if (!user->qsHash.isEmpty()) {
Global::get().db->setUserLocalVolume(user->qsHash, user->getLocalVolumeAdjustments());
} else {
Global::get().mw->logChangeNotPermanent(QObject::tr("Local Volume Adjustment..."), user);
}
updateLabelValue();
}
}
void UserLocalVolumeSlider::on_VolumeSlider_sliderReleased() {
ClientUser *user = ClientUser::get(m_clientSession);
if (user && user->qsHash.isEmpty()) {
Global::get().mw->logChangeNotPermanent(QObject::tr("Local Volume Adjustment..."), user);
}
}

1
src/mumble/UserLocalVolumeSlider.h
View File

@ -25,6 +25,7 @@ public:
private slots:
void on_VolumeSlider_valueChanged(int value) override;
void on_VolumeSlider_changeCompleted() override;
void on_VolumeSlider_sliderReleased();
};
#endif