mirrors/mumble
2
0
Fork 0
mirror of https://github.com/mumble-voip/mumble.git synced 2025-10-26 11:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4333: FIX(talking-ui): Make TalkingUI float with tiling WMs

Browse Source 
With tiling window managers (e.g. i3) the TalkingUI was seen as any
other regular window and thus it was assigned its own screen space.
This is however unfitting for the TalkingUI as it is meant to take the
least amount of possible screen space.

The solution is thus to mark the TalkingUI as floatable in order to
bypass the WM's tiling logic. In order to do so, the TalkingUI is now
marked as a dialog. Dialogs however also show the "?" button in the
title bar by default, which had to explicitly be disabled as it is
absolutely useless for the TalkingUI anyways.

Fixes #4324
This commit is contained in:
Robert Adam 2020-07-01 18:26:57 +02:00 committed by GitHub
commit e62d5abb31
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/mumble/TalkingUI.cpp
View File

@ -51,7 +51,12 @@ void TalkingUI::setupUI() {
setWindowTitle(QObject::tr("Talking UI"));
setAttribute(Qt::WA_ShowWithoutActivating);
setWindowFlags(Qt::Window | Qt::WindowStaysOnTopHint);
setWindowFlags(Qt::Dialog | Qt::WindowStaysOnTopHint);
// Hide the "?" (context help) button in the title bar of the widget as we don't want
// that due to it taking valuable screen space so that the title can't be displayed
// properly and as the TalkingUI doesn't provide context help anyways, this is not a big loss.
setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
connect(g.mw->qtvUsers->selectionModel(), &QItemSelectionModel::currentChanged, this, &TalkingUI::on_mainWindowSelectionChanged);
}