From b691108d3820695d51e2f4d76d1ee080e9bfaa91 Mon Sep 17 00:00:00 2001 From: Robert Adam Date: Wed, 10 Jun 2020 16:10:27 +0200 Subject: [PATCH] REFAC(crypto): remove QSslSocket::addDefaultCaCertificates The function in question has been deprecated in Qt 5.15. Instead it is recommended to set the CA certificates on the QSslConfiguration object. According to the docs of QSslConfiguration however the system's CA certificates is what is used by default anyways. Quote (from 5.15 docs of QSslConfiguration::systemCaCertificates): "This function provides the CA certificate database provided by the operating system. The CA certificate database returned by this function is used to initialize the database returned by caCertificates() on the default QSslConfiguration." --- src/SSL.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/SSL.cpp b/src/SSL.cpp index e00499211..3d3399de3 100644 --- a/src/SSL.cpp +++ b/src/SSL.cpp @@ -108,8 +108,6 @@ out: } void MumbleSSL::addSystemCA() { - QSslSocket::addDefaultCaCertificates(QSslConfiguration::systemCaCertificates()); - #ifdef Q_OS_WIN // Work around issue #1271. // Skype's click-to-call feature creates an enormous