diff --git a/COMMIT_GUIDELINES.md b/COMMIT_GUIDELINES.md index 3f19780dc..755013f46 100644 --- a/COMMIT_GUIDELINES.md +++ b/COMMIT_GUIDELINES.md @@ -52,6 +52,7 @@ The `TYPE` is one of the following: | BUILD | Changes related to the build process / buildsystem | Fix cmake script | | TRANSLATION | Translation updates and changes | Update translation files | | CHANGE | Something was changed without falling into existing categories | Changed the default of a setting | +| REVERT | A previous commit had to be reverted because e.g. it was buggy | - | The `TYPE` has to be in **all-uppercase** in order for it to stand out. diff --git a/macx/scripts/osxdist.py b/macx/scripts/osxdist.py index 2697079c3..39558c37d 100755 --- a/macx/scripts/osxdist.py +++ b/macx/scripts/osxdist.py @@ -248,32 +248,15 @@ class DiskImage(FolderObject): Create the disk image itself. ''' print ' * Creating diskimage. Please wait...' - if not self.filename.endswith(".dmg"): - self.filename += ".dmg" if os.path.exists(self.filename): os.remove(self.filename) - # First create an intermediate, uncompressed image. We do this as otherwise it often happens that - # hdiutils fails with the message "no space left on device" which doesn't seem to appear without compression - intermediateName = self.filename.replace(".dmg", "_intermediate.dmg") p = Popen(['hdiutil', 'create', '-srcfolder', self.tmp, - '-format', 'UDRW', - '-volname', self.volname, - '-verbose', - intermediateName]) - retval = p.wait() - if retval != 0: - raise Exception("Creating intermediate dmg file failed") - - # Now take that intermediate and compress it - p = Popen(['hdiutil', 'convert', - intermediateName, '-format', 'UDBZ', - '-verbose', '-o', + '-volname', self.volname, + '-megabytes', '130', self.filename]) retval = p.wait() - if retval != 0: - raise Exception("Compressing dmg file failed") print ' * Removing temporary directory.' shutil.rmtree(self.tmp) print ' * Done!' diff --git a/scripts/commitMessage/CommitMessage.py b/scripts/commitMessage/CommitMessage.py index 461b49b90..c0fd14a96 100644 --- a/scripts/commitMessage/CommitMessage.py +++ b/scripts/commitMessage/CommitMessage.py @@ -11,7 +11,7 @@ class CommitFormatError(Exception): Exception(msg) class CommitMessage: - knownTypes = ["BREAK", "FEAT", "FIX", "FORMAT", "DOCS", "TEST", "MAINT", "CI", "REFAC", "BUILD", "TRANSLATION", "CHANGE"] + knownTypes = ["BREAK", "FEAT", "FIX", "FORMAT", "DOCS", "TEST", "MAINT", "CI", "REFAC", "BUILD", "TRANSLATION", "CHANGE", "REVERT"] def __init__(self, commitString): lines = commitString.strip().split("\n") diff --git a/scripts/generateChangelog.py b/scripts/generateChangelog.py index b26c971d9..2bcaa13f4 100755 --- a/scripts/generateChangelog.py +++ b/scripts/generateChangelog.py @@ -94,6 +94,8 @@ def main(): prefix = "Fixed: " elif "CHANGE" in commit.m_types: prefix = "Changed: " + elif "REVERT" in commit.m_types: + prefix = "Reverted: " else: prefix = "Unknown: "