From 8fe9be82ab8227403b8a219c53d0a841f0331c72 Mon Sep 17 00:00:00 2001 From: Robert Adam Date: Wed, 28 Oct 2020 18:38:29 +0100 Subject: [PATCH] BUILD(cmake): Fix quoting for compile defs It seems that the quotes added in a target_add_compile_definitions call are taken literal and will be part of the actual macro definition. What we actually wanted was that paths with spaces are properly covered which can be achieved by placing the starting quote a bit differently. --- src/mumble/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mumble/CMakeLists.txt b/src/mumble/CMakeLists.txt index 2a1a6c33a..e0d32087a 100644 --- a/src/mumble/CMakeLists.txt +++ b/src/mumble/CMakeLists.txt @@ -291,8 +291,8 @@ endif() target_compile_definitions(mumble PRIVATE - MUMBLE_LIBRARY_PATH="${MUMBLE_INSTALL_LIBDIR}" - MUMBLE_PLUGIN_PATH="${MUMBLE_INSTALL_PLUGINDIR}" + "MUMBLE_LIBRARY_PATH=${MUMBLE_INSTALL_LIBDIR}" + "MUMBLE_PLUGIN_PATH=${MUMBLE_INSTALL_PLUGINDIR}" ) set_target_properties(mumble