From 45e2d2419cad3e78b17327be6e42bfd6986c6f66 Mon Sep 17 00:00:00 2001 From: Davide Beatrici Date: Sun, 9 Aug 2020 20:28:25 +0200 Subject: [PATCH] FEAT(client): print extended error when QOSRemoveSocketFromFlow() fails This should help us investigate why a crash happens immediately after the function fails on Windows 10 Insider Build 20185. --- src/mumble/ServerHandler.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mumble/ServerHandler.cpp b/src/mumble/ServerHandler.cpp index 2dcfc7298..a75c5cc97 100644 --- a/src/mumble/ServerHandler.cpp +++ b/src/mumble/ServerHandler.cpp @@ -426,8 +426,10 @@ void ServerHandler::run() { #ifdef Q_OS_WIN if (hQoS) { - if (! QOSRemoveSocketFromFlow(hQoS, 0, dwFlowUDP, 0)) - qWarning("ServerHandler: Failed to remove UDP from QoS"); + if (!QOSRemoveSocketFromFlow(hQoS, 0, dwFlowUDP, 0)) { + qWarning("ServerHandler: Failed to remove UDP from QoS. QOSRemoveSocketFromFlow() failed with error %u!", GetLastError()); + } + dwFlowUDP = 0; } #endif