mirrors/mumble
2
0
Fork 0
mirror of https://github.com/mumble-voip/mumble.git synced 2025-10-26 11:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

CHANGE(server): Untrimmed usernames considered invalid

Browse Source 
When checking whether a given username is valid, it being trimmed is now
also a criterion. All names with leading and/or trailing whitespace will
be considered invalid from now on.
This commit is contained in:
Robert Adam 2021-04-11 13:24:41 +02:00
parent 90190bcb01
commit 58fee9705d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/murmur/Server.cpp
View File

@ -2092,7 +2092,9 @@ QString Server::addressToString(const QHostAddress &adr, unsigned short port) {
}
bool Server::validateUserName(const QString &name) {
return (qrUserName.exactMatch(name) && (name.length() <= 512));
// We expect the name passed to this function to be fully trimmed already. This way we
// prevent "empty" names (at least with the default username restriction).
return (name.trimmed().length() == name.length() && qrUserName.exactMatch(name) && (name.length() <= 512));
}
bool Server::validateChannelName(const QString &name) {