mirrors/mumble
2
0
Fork 0
mirror of https://github.com/mumble-voip/mumble.git synced 2025-10-26 11:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Try to fix channel limit override by subchan delete

Browse Source 
Try to remove the ability to join a full channel by
creating a temporary sub channel then joining it
and removing it (discovered by @Natenom).

Check isChannelFull in addition to existing
hasPermissions ChanACL::Enter check.
This commit is contained in:
Felix Becker 2019-11-03 23:37:35 +01:00
parent ccdb88f872
commit 2faf905167
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/murmur/Server.cpp
View File

@ -1626,7 +1626,7 @@ void Server::removeChannel(Channel *chan, Channel *dest) {
}
Channel *target = dest;
while (target->cParent && ! hasPermission(static_cast<ServerUser *>(p), target, ChanACL::Enter))
while (target->cParent && (! hasPermission(static_cast<ServerUser *>(p), target, ChanACL::Enter) || isChannelFull(target, static_cast<ServerUser *>(p))))
target = target->cParent;
MumbleProto::UserState mpus;