mirrors/mumble
2
0
Fork 0
mirror of https://github.com/mumble-voip/mumble.git synced 2025-10-26 11:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge PR #5438: FEAT(client): Industry standard for hold time

Browse Source 
As request in #2453, this commit implements the industry standard
for microphone hold time for voice activation detection. The calculation
that yields hold time (s) from the iVoiceHold setting is described and
comments are added to describe the function of related fields.

Implements #2453.
This commit is contained in:
Robert Adam 2022-01-25 17:22:16 +01:00 committed by GitHub
commit 0e204e1d61
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mumble/AudioInput.cpp
View File

@ -1070,6 +1070,7 @@ void AudioInput::encodeAudioFrame(AudioChunk chunk) {
if (!bIsSpeech) {
iHoldFrames++;
if (iHoldFrames < Global::get().s.iVoiceHold)
// Hold mic open until iVoiceHold threshold is reached
bIsSpeech = true;
} else {
iHoldFrames = 0;

6
src/mumble/AudioInput.h
View File

@ -210,8 +210,12 @@ protected:
bool bEchoMulti;
Settings::NoiseCancel noiseCancel;
// Standard microphone sample rate (samples/s)
static const unsigned int iSampleRate = SAMPLE_RATE;
static const int iFrameSize = SAMPLE_RATE / 100;
/// Based the sample rate, 48,000 samples/s = 48 samples/ms.
/// For each 10 ms, this yields 480 samples. This corresponds numerically with the calculation:
/// iFrameSize = 48000 / 100 = 480 samples, allowing a consistent 10ms of audio data per frame.
static const int iFrameSize = SAMPLE_RATE / 100;
QMutex qmSpeex;
SpeexPreprocessState *sppPreprocess;

8
src/mumble/Settings.cpp
View File

@ -323,9 +323,11 @@ Settings::Settings() {
bOnlyAttenuateSameOutput = false;
bAttenuateLoopbacks = false;
iMinLoudness = 1000;
iVoiceHold = 50;
iJitterBufferSize = 1;
iFramesPerPacket = 2;
/// Actual mic hold time is (iVoiceHold / 100) seconds, where iVoiceHold is specified in 'frames',
/// each of which is has a size of iFrameSize (see AudioInput.h)
iVoiceHold = 20;
iJitterBufferSize = 1;
iFramesPerPacket = 2;
#ifdef USE_RNNOISE
noiseCancelMode = NoiseCancelRNN;
#else