mirrors/ipscan
2
0
Fork 0
mirror of https://github.com/angryip/ipscan.git synced 2025-10-26 11:18:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

unfortunately, HashMap.computeIfAbsent() doesn't store values properly in a recursive scenario

Browse Source
This commit is contained in:
Anton Keks 2020-05-17 16:52:21 +03:00
parent 211803739e
commit ad71723902
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/net/azib/ipscan/di/Injector.java
View File

@ -24,7 +24,14 @@ public class Injector {
}
<T> T require(Key<T> key) {
return (T) instances.computeIfAbsent(key, k -> createInstance(key.type));
T value = (T) instances.get(key);
if (value == null) {
value = createInstance(key.type);
instances.put(key, value);
}
return value;
// unfortunately, HashMap.computeIfAbsent() doesn't put values properly in a recursive scenario
// return (T) instances.computeIfAbsent(key, k -> createInstance(k.type));
}
public <T> T require(Class<T> type) {
@ -67,8 +74,7 @@ public class Injector {
}
private boolean isCollection(Type type) {
return type instanceof ParameterizedType &&
Collection.class.isAssignableFrom(toClass(type));
return type instanceof ParameterizedType && Collection.class.isAssignableFrom(toClass(type));
}
private Class<?> getParamClass(ParameterizedType type) {