From fc881e2ffff6e4d19db68e3735bacde7220c48da Mon Sep 17 00:00:00 2001 From: Lukas Zumvorde Date: Thu, 11 Feb 2021 15:19:39 +0100 Subject: [PATCH] univention_config_registry does not propperly fail --- library/univention_config_registry.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/univention_config_registry.py b/library/univention_config_registry.py index 28107bf..8bf4213 100755 --- a/library/univention_config_registry.py +++ b/library/univention_config_registry.py @@ -123,7 +123,7 @@ def _set_keys(keys, result, module): result['rc'] = rc result['message'] = "These keys were set: {}".format(" ".join(to_set)) result['meta']['changed_keys'] = to_set - result['failed'] = rc != 0 + result['failed'] = rc != 0 or len(err) > 0 if rc != 0: module.fail_json(msg='non-zero return code', **result) @@ -160,7 +160,7 @@ def _unset_keys(keys, result, module): result['rc'] = rc result['message'] = "These keys were unset: {}".format(" ".join(to_unset)) result['meta']['changed_keys'] = to_unset - result['failed'] = rc != 0 + result['failed'] = rc != 0 if rc != 0: module.fail_json(msg='non-zero return code', **result)