mirrors/Remotely
3
0
Fork 0
mirror of https://github.com/immense/Remotely.git synced 2025-10-26 11:27:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return early if device not found.

Browse Source
This commit is contained in:
Jared Goodwin 2020-03-29 11:42:26 -07:00
parent 15a5febf76
commit dc5bf743eb
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Server/Pages/EditDevice.cshtml.cs
View File

@ -35,15 +35,22 @@ namespace Remotely.Server.Pages
public IActionResult OnGet(string deviceID, bool success)
{
var user = DataService.GetUserByName(User.Identity.Name);
if (!DataService.DoesUserHaveAccessToDevice(deviceID, user))
var targetDevice = DataService.GetDevice(deviceID);
if (targetDevice == null)
{
return Page();
}
else if (!DataService.DoesUserHaveAccessToDevice(deviceID, user))
{
var targetDevice = DataService.GetDevice(deviceID);
DataService.WriteEvent($"Edit device attempted by unauthorized user. Device ID: {deviceID}. User Name: {user.UserName}.",
Remotely.Shared.Models.EventType.Warning,
targetDevice.OrganizationID);
return Unauthorized();
}
SaveSucessful = success;
else
{
SaveSucessful = success;
}
PopulateViewModel(deviceID);
return Page();
@ -70,7 +77,7 @@ namespace Remotely.Server.Pages
var device = DataService.GetDevice(user.OrganizationID, deviceID);
DeviceName = device?.DeviceName;
DeviceID = device?.ID;
AgentVersion = device.AgentVersion;
AgentVersion = device?.AgentVersion;
Input.Alias = device?.Alias;
Input.DeviceGroupID = device?.DeviceGroupID;
Input.Tags = device?.Tags;